Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign / rewrite rustdoc #5413

Closed
brson opened this issue Mar 16, 2013 · 6 comments
Closed

Redesign / rewrite rustdoc #5413

brson opened this issue Mar 16, 2013 · 6 comments
Labels
metabug Issues about issues themselves ("bugs about bugs") T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@brson
Copy link
Contributor

brson commented Mar 16, 2013

Rustdoc was implemented for Rust 0.1 and a lot about the language has changed since then. Both the way it presents certain features and the way it's implemented are relics. It's never been particularly good and probably deserves a comprehensive redesign.
@ghost ghost assigned z0w0 May 21, 2013
@graydon graydon mentioned this issue Jun 20, 2013
Closed
@graydon
Copy link
Contributor

graydon commented Jun 20, 2013

accepted for backwards-compatible milestone

@graydon
Copy link
Contributor

graydon commented Jun 20, 2013

(because this will likely change command-line interface to the tool)

@msullivan msullivan mentioned this issue Jun 21, 2013
Open
@emberian
Copy link
Member

I'm actively doing this

@pnkfelix pnkfelix mentioned this issue Jul 16, 2013
Closed
This was referenced Jul 25, 2013
Closed
Closed
@emberian
Copy link
Member

emberian commented Aug 5, 2013

bam, done. yay!

@emberian emberian closed this as completed Aug 5, 2013
@msullivan msullivan mentioned this issue Aug 10, 2013
Open
@emberian
Copy link
Member

#8125

@emberian
Copy link
Member

Now that rustdoc_ng has been merged, closing.

@emberian emberian reopened this Sep 18, 2013
@brson brson unassigned z0w0 Jun 16, 2014
@killercup killercup mentioned this issue May 14, 2015
Closed
oli-obk pushed a commit to oli-obk/rust that referenced this issue May 2, 2020
@rabisg0
Check fn header along with decl when suggesting to implement trait
c2e5534 
When checking for functions that are potential candidates for trait
implementations check the function header to make sure modifiers like
asyncness, constness and safety match before triggering the lint.

Fixes rust-lang#5413, rust-lang#4290
oli-obk pushed a commit to oli-obk/rust that referenced this issue May 2, 2020
@bors
Auto merge of rust-lang#5437 - rabisg0:should-impl-trait, r=flip1995
940bbd6 
Check fn header along with decl when suggesting to implement trait

When checking for functions that are potential candidates for trait
implementations check the function header to make sure modifiers like
asyncness, constness and safety match before triggering the lint.

Fixes rust-lang#5413, rust-lang#4290

changelog: check fn header along with decl for should_implement_trait
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
metabug Issues about issues themselves ("bugs about bugs") T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@graydon @steveklabnik @alexcrichton @brson @z0w0 @emberian