Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filter to rustc_on_unimplemented for Self: array #53766

Closed
estebank opened this issue Aug 28, 2018 · 0 comments · Fixed by #54946
Closed

Add filter to rustc_on_unimplemented for Self: array #53766

estebank opened this issue Aug 28, 2018 · 0 comments · Fixed by #54946
Labels
A-diagnostics Area: Messages for errors, warnings, and lints

Comments

@estebank
Copy link
Contributor

In order to merge #52178, we need to be able to target arrays, so we don't completely lose the suggestion to use .iter() for them.
@estebank estebank added the A-diagnostics Area: Messages for errors, warnings, and lints label Aug 28, 2018
This was referenced Aug 28, 2018
Closed
Open
@estebank estebank mentioned this issue Oct 10, 2018
Merged
bors added a commit that referenced this issue Oct 15, 2018
@bors
Auto merge of #54946 - estebank:iterator, r=<try>
2b66d93 
Add filtering option to `rustc_on_unimplemented` and reword `Iterator` E0277 errors

 - Add more targetting filters for arrays to `rustc_on_unimplemented` (Fix #53766)
 - Detect one element array of `Range` type, which is potentially a typo:
   `for _ in [0..10] {}` where iterating between `0` and `10` was intended.
   (Fix #23141)
 - Suggest `.bytes()` and `.chars()` for `String`.
 - Suggest borrowing or `.iter()` on arrays (Fix #36391)
 - Suggest using range literal when iterating on integers (Fix #34353)
 - Do not suggest `.iter()` by default (Fix #50773, fix #46806)
 - Add regression test (Fix #22872)
bors added a commit that referenced this issue Oct 17, 2018
@bors
Auto merge of #54946 - estebank:iterator, r=varkor
1dceadd 
Add filtering option to `rustc_on_unimplemented` and reword `Iterator` E0277 errors

 - Add more targetting filters for arrays to `rustc_on_unimplemented` (Fix #53766)
 - Detect one element array of `Range` type, which is potentially a typo:
   `for _ in [0..10] {}` where iterating between `0` and `10` was intended.
   (Fix #23141)
 - Suggest `.bytes()` and `.chars()` for `String`.
 - Suggest borrowing or `.iter()` on arrays (Fix #36391)
 - Suggest using range literal when iterating on integers (Fix #34353)
 - Do not suggest `.iter()` by default (Fix #50773, fix #46806)
 - Add regression test (Fix #22872)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add filtering option to rustc_on_unimplemented and reword Iterator E0277 errors estebank/rust
1 participant
@estebank