Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#[proc_macro] and #[proc_macro_attribute] can silently accept a value with = #52273

Closed
petrochenkov opened this issue Jul 11, 2018 · 0 comments
Closed

#[proc_macro] and #[proc_macro_attribute] can silently accept a value with = #52273

petrochenkov opened this issue Jul 11, 2018 · 0 comments
Labels
A-macros-1.2 Area: Declarative macros 1.2 E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@petrochenkov
Copy link
Contributor

For example, #[proc_macro = "abc"] and #[proc_macro_attribute = "def"].
@petrochenkov petrochenkov added A-macros-1.2 Area: Declarative macros 1.2 E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Jul 11, 2018
alexcrichton added a commit to alexcrichton/rust that referenced this issue Jul 11, 2018
@alexcrichton
rustc: Verify #[proc_macro] is only a word
7735f45 
... and perform the same verification for #[proc_macro_attribute], currently
neither of these attributes take any arguments.

Closes rust-lang#52273
@alexcrichton alexcrichton mentioned this issue Jul 11, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this issue Jul 12, 2018
@kennytm
Rollup merge of rust-lang#52276 - alexcrichton:validate-proc-macro-at…
63cc55b 
…tr, r=petrochenkov

rustc: Verify #[proc_macro] is only a word

... and perform the same verification for #[proc_macro_attribute], currently
neither of these attributes take any arguments.

Closes rust-lang#52273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-macros-1.2 Area: Declarative macros 1.2 E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@petrochenkov