Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance regression between 3/1 and 3/2 #48660

Closed
ishitatsuyuki opened this issue Mar 2, 2018 · 3 comments
Closed

Performance regression between 3/1 and 3/2 #48660

ishitatsuyuki opened this issue Mar 2, 2018 · 3 comments
Assignees
@sgrif
Labels
C-bug Category: This is a bug. I-compiletime Issue: Problems and improvements with respect to compile times. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@ishitatsuyuki
Copy link
Contributor

Per #47861 (comment).
@ishitatsuyuki ishitatsuyuki added I-compiletime Issue: Problems and improvements with respect to compile times. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-bug Category: This is a bug. labels Mar 2, 2018
@nikomatsakis nikomatsakis mentioned this issue Mar 2, 2018
Merged
@nikomatsakis
Copy link
Contributor

This was caused by #47861, it seems. cc @sgrif. Rather surprising since we did measurements beforehand though!

@nikomatsakis
Copy link
Contributor

I'm inclined to roll it back and try landing again after doing more investigation, though I'd not be opposed to doing some quick measurements to see if we can identify the problem.

@sgrif
Copy link
Contributor

sgrif commented Mar 2, 2018

ccd92c2 was meant to be removed from that PR, but somehow I accidentally re-added it. I'll see if I can cleanly just revert that one commit.

@sgrif sgrif self-assigned this Mar 2, 2018
@sgrif sgrif mentioned this issue Mar 2, 2018
Merged
bors added a commit that referenced this issue Mar 3, 2018
@bors
Auto merge of #48666 - sgrif:sg-revert-perf-regression, r=nikomatsakis
5f1f628 
Revert "correct subtle bug in the type variable code"

This reverts commit ccd92c2.

This commit is the source of a major perf regression, and was not
intended to be included in #47861. At some point I must have
accidentally re-added the commit.

Fixes #48660.

r? @nikomatsakis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrif sgrif

Labels
C-bug Category: This is a bug. I-compiletime Issue: Problems and improvements with respect to compile times. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nikomatsakis @sgrif @ishitatsuyuki