Non-ANSI paths cause rustc to fail to link on windows #48318
Assignees
Labels
C-bug
Category: This is a bug.
O-windows
Operating system: Windows
P-high
High priority
regression-from-stable-to-stable
Performance or correctness regression from one stable version to another.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
|
UPD: |
|
cc @retep998 @aturon @alexcrichton It seems odd that this would be the case and our bots didn't catch it. @InnocentusLime Could you provide the exact command and the log that you get? |
Mark-Simulacrum
added
T-compiler
|
I'm having a similar issue on windows, the MSVC |
|
I believe #47507 is what has triggered the error @negamartin is seeing. The
So |
|
I'd suspect that's the root cause here for the original reporter as well. We probably want to encode into UTF-16... but I'm not entirely sure how easy that would be to do. |
Mark-Simulacrum
changed the title
|
We already have EDIT: Actually... the hardest part might be the fact that technically rustc can attempt to invoke |
|
The compilation was invoked using If you still need it, here's a big piece (not the full log) of log that was printed on the screen: tl;dr |
|
@InnocentusLime If you set your console to be UTF-8 using |
|
@retep998 Unfortunately, after I tried the |
|
Thanks for the report @InnocentusLime as well as the extra information @negamartin! Additionally thanks @ollie27 for pinpointing this, that sounds like exactly the issue! I believe this will be a relatively easy bug to fix in rustc itself. The file that we pass to |
|
@alexcrichton do you plan to open a PR to fix? Seems like this would be best done by somebody with a windows setup, I guess? |
|
triage: P-high |
|
Could someone with access to a windows machine test whether building the branch from #48445 fixes this PR? I don't have a windows machine to test on myself. |
|
I've tested e04adee27fd235b44f43ae72069e71036ff3ee0b applied to master and it seems to work and fix this issue. The |
|
@ollie27 is that commit from a PR? I don't see it linked on this issue... |
|
@nikomatsakis that commit was in #48445 but it looks like @Mark-Simulacrum has amended it to fix the tests. |
|
I believe this is in theory fixed on the beta channel currently (soon coming to nightly as well). @InnocentusLime and @negamartin, can y'all test out the beta channel and see if it works where stable doesn't? |
bors
added a commit
that referenced
this issue
Feb 27, 2018
[stable] 1.24.1 stable release The includes the following commits: - 6a600f8: Fixes #48251, unwinding through FFI no longer aborts - cuviper@b445a52: Fixes #48308, fixing the error index generator - f8e00d0: Fixes #48318 by emitting UTF-16 output on MSVC targets. - 2a0af8c448: Bumps the version number to 1.24.1. - 93220f0f45: Release notes - 6031718d8836f95bbfeddfaa63f1ee1d66e53f26: Cargo TLS warnings on Windows.
|
Independently of @alexcrichton 's request: Hey @nagisa , did you say you could give this a whirl on a Windows VM you have handy? Is that offer still open? It would be good to have someone on the rustc team take point on this in some manner. |
|
I'll try to get to this this weekend.
…On Mar 1, 2018 17:12, "Felix S Klock II" ***@***.***> wrote:
Independently of @alexcrichton <https://github.com/alexcrichton> 's
request: Hey @nagisa <https://github.com/nagisa> , did you say you could
give this a whirl on a Windows VM you have handy? Is that offer still open?
It would be good to have someone on the rustc team take point on this in
some manner.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#48318 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AApc0rRdkAS98919NGPPY11LXOlc4gU4ks5taA_XgaJpZM4SJn7u>
.
|
|
This issue has indeed been fixed according to my local testing. |
|
Since it has been backported to stable, assuming fixed there as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello!
After installing the brand new rust 1.24 toolset on my windows machine the rustc started refusing to compile any of the projects that were linking to libraries from crates.io.
Both gnu and msvc toolchains linkers claim that they can't find some files (the msvc for example can't find .o files).
Reinstalling rust toolset and removing all cache doesn't help. The only thing that stops that issue is rolling back to 1.23. And that makes me think that is has something to do with rustc 1.24.
Thank you in advance.
The text was updated successfully, but these errors were encountered: