Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for DoubleEndedIterator::rfold (feature iter_rfold) #44705

Closed
bluss opened this issue Sep 19, 2017 · 8 comments
Closed

Tracking issue for DoubleEndedIterator::rfold (feature iter_rfold) #44705

bluss opened this issue Sep 19, 2017 · 8 comments
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@bluss
Copy link
Member

bluss commented Sep 19, 2017 •
edited
Loading

This is a tracking issue for DoubleEndedIterator::rfold (feature iter_rfold)
@sfackler sfackler added B-unstable Blocker: Implemented in the nightly compiler and unstable. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Sep 19, 2017
@TimNN TimNN added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Sep 20, 2017
@bluss
Copy link
Member Author

bluss commented Oct 2, 2017

More rfold impls in #44856

@cuviper cuviper mentioned this issue Nov 8, 2017
Closed
4 tasks
@scottmcm
Copy link
Member

Is this ready for a stabilization PR? I don't think there are any open questions...

@bluss
Copy link
Member Author

bluss commented Nov 19, 2017

I'd love to see this stabilized too.

The trait question where to place it (same as rfind) is the only one. I'm interested in what others think about that.

@SimonSapin
Copy link
Contributor

Looks good to me to stabilize.

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Mar 17, 2018 •
edited by aturon
Loading

Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Mar 17, 2018
@withoutboats
Copy link
Contributor

I'm glad this was implemented on DoubleEndedIterator. The more niche methods are added to Iterator, the harder it is for users (especially new users) to find the non-niche method they're looking for. Since this method is extremely niche (an optimization of a very uncommon operation - folding in reverse), I think it would be "method bloat" to add it to Iterator.

I'm just noting this because I was going to register a concern about adding this to Iterator until I saw that it was added to DoubleEndedIterator instead.

@scottmcm scottmcm mentioned this issue Mar 17, 2018
Closed
@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Mar 17, 2018
@rfcbot
Copy link

rfcbot commented Mar 17, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot
Copy link

rfcbot commented Mar 27, 2018

The final comment period is now complete.

@cuviper cuviper mentioned this issue Apr 3, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this issue Apr 4, 2018
@kennytm
Rollup merge of rust-lang#49607 - cuviper:stable-iter-1.27, r=alexcri…
dd2ec6a 
…chton

Stabilize iterator methods in 1.27

- Closes rust-lang#39480, feature  `iter_rfind`
  - `DoubleEndedIterator::rfind`
- Closes rust-lang#44705, feature `iter_rfold`
  - `DoubleEndedIterator::rfold`
- Closes rust-lang#45594, feature `iterator_try_fold`
  - `Iterator::try_fold`
  - `Iterator::try_for_each`
  - `DoubleEndedIterator::try_rfold`
@remram44 remram44 mentioned this issue Oct 3, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@SimonSapin @TimNN @sfackler @bluss @withoutboats @scottmcm @rfcbot