Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unused_extern_crates false positives #42591

Closed
ishitatsuyuki opened this issue Jun 11, 2017 · 0 comments · Fixed by #42588
Closed

unused_extern_crates false positives #42591

ishitatsuyuki opened this issue Jun 11, 2017 · 0 comments · Fixed by #42588
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-bug Category: This is a bug.

Comments

@ishitatsuyuki
Copy link
Contributor

ishitatsuyuki commented Jun 11, 2017 •
edited
Loading

List of crates that can suffer from the link-only false positives:

  • compiler_builtins
  • panic runtimes

Allocators used to, but not after redesign.
@ishitatsuyuki ishitatsuyuki mentioned this issue Jun 11, 2017
Merged
@Mark-Simulacrum Mark-Simulacrum added the A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. label Jun 23, 2017
@Mark-Simulacrum Mark-Simulacrum changed the title unused_extern_crates false positive: alloc_system unused_extern_crates false positives Jun 23, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-bug Category: This is a bug. label Jul 27, 2017
bors added a commit that referenced this issue Aug 27, 2017
@bors
Auto merge of #42588 - ishitatsuyuki:patch-1, r=petrochenkov
78e95bb 
Make unused-extern-crate warn-by-default

Apart from enabling the lint, this pull request also removes existing unused crates in the codebase, and fix some amount of false positives on crates with special purposes.

Now that all false positive issues are closed, it should be possible to make it available to wider users.

Quote:
> Now that macro modularization is implemented, this is true today! *#30849 (comment)

Concerns: can break some `#[deny(warnings)]`.

Close #42591
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make unused-extern-crate warn-by-default ishitatsuyuki/rust
2 participants
@Mark-Simulacrum @ishitatsuyuki