Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Box<DST> special code from trans now that the box_free lang item supports them #37710

Closed
oli-obk opened this issue Nov 11, 2016 · 0 comments
Closed

remove Box<DST> special code from trans now that the box_free lang item supports them #37710

oli-obk opened this issue Nov 11, 2016 · 0 comments

Comments

@oli-obk
Copy link
Contributor

oli-obk commented Nov 11, 2016

#37708 changed box_free to be equivalent to a future Drop impl for Box<T: ?Sized>. Unfortunately trans still has some specialized code around Box<DST> (basically generating the same code as box_free) when it could just be calling box_free.
@Mark-Simulacrum Mark-Simulacrum mentioned this issue Dec 23, 2016
Merged
bors added a commit that referenced this issue Dec 27, 2016
@bors
Auto merge of #38574 - Mark-Simulacrum:box-free-unspecialize, r=eddyb
d849b13 
Remove special case for Box<ZST> in trans

Remove extra lang item, `exchange_free`; use `box_free` instead.

Trans used to insert code equivalent to `box_free` in a wrapper around
`exchange_free`, and that code is now removed from trans.

Fixes #37710.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oli-obk