Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errant edge to krate node #36168

Closed
nikomatsakis opened this issue Aug 31, 2016 · 3 comments
Closed

Errant edge to krate node #36168

nikomatsakis opened this issue Aug 31, 2016 · 3 comments
Labels
A-incr-comp Area: Incremental compilation T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
Incremental compi...

Comments

@nikomatsakis
Copy link
Contributor

I noticed when checking the syntex-syntax node that, when I add a private fn into the crate module, it invalidates the krate-0 module. This is because the metadata includes edges to the immediate children. This seems bad, but then there is also a read whenever we read an inlined item from crate X of the crate root, which means that this winds up triggering bad reuse. I am trying to figure out why this read arises and remove it, but I'd also like to remove the dependency of metadata.
@nikomatsakis nikomatsakis added I-wrong T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-incr-comp Area: Incremental compilation labels Aug 31, 2016
@nikomatsakis nikomatsakis added this to the Incremental compilation alpha milestone Aug 31, 2016
@michaelwoerister
Copy link
Member

Was this fixed by c6363b8?

@nikomatsakis
Copy link
Contributor Author

@michaelwoerister quite likely; I guess I will make a perf test to check

@nikomatsakis nikomatsakis mentioned this issue Nov 21, 2016
Merged
@nikomatsakis
Copy link
Contributor Author

nikomatsakis commented Nov 21, 2016 •
edited
Loading

Looks good. Posted a PR with a test.

nikomatsakis added a commit to nikomatsakis/rust that referenced this issue Nov 28, 2016
@nikomatsakis
add regression test for rust-lang#36168
dac987e 
Fixes rust-lang#36168
dns2utf8 added a commit to dns2utf8/rust that referenced this issue Dec 1, 2016
@dns2utf8
Rollup merge of rust-lang#37919 - nikomatsakis:incremental-36168, r=mw
9709dba 
add regression test for rust-lang#36168

Fixes rust-lang#36168

r? @michaelwoerister
frewsxcv added a commit to frewsxcv/rust that referenced this issue Dec 3, 2016
@frewsxcv
Rollup merge of rust-lang#37919 - nikomatsakis:incremental-36168, r=mw
8916acc 
add regression test for rust-lang#36168

Fixes rust-lang#36168

r? @michaelwoerister
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-incr-comp Area: Incremental compilation T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
Incremental compilation beta
Development

No branches or pull requests
2 participants
@nikomatsakis @michaelwoerister