Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E0365 needs to be updated to new format #35633

Closed
sophiajt opened this issue Aug 13, 2016 · 1 comment
Closed

E0365 needs to be updated to new format #35633

sophiajt opened this issue Aug 13, 2016 · 1 comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

From: src/test/compile-fail/E0365.rs

E0365 needs a span_label and a span_note changed to a note, updating it from:

error[E0365]: `foo` is private, and cannot be reexported
  --> src/test/compile-fail/E0365.rs:15:9
   |
15 | pub use foo as foo2; //~ ERROR E0365
   |         ^^^^^^^^^^^
   |
note: consider declaring type or module `foo` with `pub`
  --> src/test/compile-fail/E0365.rs:15:9
   |
15 | pub use foo as foo2; //~ ERROR E0365
   |         ^^^^^^^^^^^

To:

error[E0365]: `foo` is private, and cannot be reexported
  --> src/test/compile-fail/E0365.rs:15:9
   |
15 | pub use foo as foo2; //~ ERROR E0365
   |         ^^^^^^^^^^^ reexport of private `foo`
   |
   = note: consider declaring type or module `foo` with `pub`
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 13, 2016
@GuillaumeGomez GuillaumeGomez mentioned this issue Aug 13, 2016
Closed
@Xinayder
Copy link
Contributor

I'm working on this.

@Xinayder Xinayder mentioned this issue Aug 14, 2016
Merged
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 15, 2016
Rollup merge of rust-lang#35670 - RockyTV:e0365, r=jonathandturner
cf2a53a 
Update error E0365 to new format

Fixes rust-lang#35633 as part of rust-lang#35233.

r? @jonathandturner
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 17, 2016
Rollup merge of rust-lang#35670 - RockyTV:e0365, r=jonathandturner
5b6e6dc 
Update error E0365 to new format

Fixes rust-lang#35633 as part of rust-lang#35233.

r? @jonathandturner
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 17, 2016
Rollup merge of rust-lang#35670 - RockyTV:e0365, r=jonathandturner
02a8e2c 
Update error E0365 to new format

Fixes rust-lang#35633 as part of rust-lang#35233.

r? @jonathandturner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sophiajt @Xinayder