Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0124 needs to be updated to new format #35255

Closed
sophiajt opened this issue Aug 3, 2016 · 1 comment · Fixed by #35318
Closed

E0124 needs to be updated to new format #35255

sophiajt opened this issue Aug 3, 2016 · 1 comment · Fixed by #35318
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 3, 2016

From: src/test/compile-fail/E0124.rs

Error E0124 needs a span_label and a span_note replaced with a span_label, updating it from:

error[E0124]: field `field1` is already declared
  --> src/test/compile-fail/E0124.rs:13:5
   |
13 |     field1: i32, //~ ERROR E0124
   |     ^^^^^^^^^^^
   |
note: previously declared here
  --> src/test/compile-fail/E0124.rs:12:5
   |
12 |     field1: i32,
   |     ^^^^^^^^^^^

To:

error[E0124]: field `field1` is already declared
  --> src/test/compile-fail/E0124.rs:13:5
   |
12 |     field1: i32,
   |     ----------- first declared here
13 |     field1: i32, //~ ERROR E0124
   |     ^^^^^^^^^^^ field already declared
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 3, 2016
@sciyoshi
Copy link
Contributor

sciyoshi commented Aug 4, 2016

Error message updated in #35318.

sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 4, 2016
…urner

Update E0124 to the new error format

Part of rust-lang#35233. This resolves rust-lang#35255.

r? @jonathandturner
steveklabnik added a commit to steveklabnik/rust that referenced this issue Aug 4, 2016
…urner

Update E0124 to the new error format

Part of rust-lang#35233. This resolves rust-lang#35255.

r? @jonathandturner
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Aug 5, 2016
…urner

Update E0124 to the new error format

Part of rust-lang#35233. This resolves rust-lang#35255.

r? @jonathandturner
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Aug 5, 2016
…urner

Update E0124 to the new error format

Part of rust-lang#35233. This resolves rust-lang#35255.

r? @jonathandturner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants