Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0089 needs to be updated to new format #35227

Closed
sophiajt opened this issue Aug 3, 2016 · 2 comments
Closed

E0089 needs to be updated to new format #35227

sophiajt opened this issue Aug 3, 2016 · 2 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 3, 2016

From: src/test/compile-fail/E0089.rs

Error E0089 needs a span_label, updating it from:

error[E0089]: too few type parameters provided: expected 2 parameters, found 1 parameter
  --> src/test/compile-fail/E0089.rs:14:5
   |
14 |     foo::<f64>(); //~ ERROR E0089
   |     ^^^^^^^^^^

To:

error[E0089]: too few type parameters provided: expected 2 parameters, found 1 parameter
  --> src/test/compile-fail/E0089.rs:14:5
   |
14 |     foo::<f64>(); //~ ERROR E0089
   |     ^^^^^^^^^^ expected 2 type parameters
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 3, 2016
@sophiajt
Copy link
Contributor Author

@zjhmale - I got your message. If all the unit tests pass after you make a change, you'll need to update the test by hand. If a unit test doesn't have any NOTE tests in it, it won't test any labels. When you add a NOTE to the unit test, it will test the labels. In the blog post, look for the section called Extra Credit. This will tell you how to update the tests. You can also look at other PRs, like this one to see how other people have done it.

@swr1bm86
Copy link
Contributor

@jonathandturner cool! i should read the blog post more carefully 😅 , anyway i figured it out through this, thx all the same!

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Aug 29, 2016
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Aug 30, 2016
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

2 participants