Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hardcoded paths in makefile prevent using checkinstall #3391

Closed
RonnyPfannschmidt opened this issue Sep 5, 2012 · 3 comments
Closed

hardcoded paths in makefile prevent using checkinstall #3391

RonnyPfannschmidt opened this issue Sep 5, 2012 · 3 comments

Comments

@RonnyPfannschmidt
Copy link

sudo checkinstall fails after a make due to hardcoded paths
this prevents installing as normal package from the repo
@catamorphism
Copy link
Contributor

Not critical for 0.6, de-milestoning

@bstrie
Copy link
Contributor

bstrie commented May 20, 2013

@catamorphism, is it safe to presume that rustc itself will start using rustpkg at some point? If so, is it enough to provide an uninstallation facility with rustpkg, or would it still need to be able to work through checkinstall?

@catamorphism
Copy link
Contributor

@bstrie Yes -- #2237 is already open to move rust to being built with rustpkg. That won't be done for a while, but in the meantime, this particular issue doesn't seem super urgent, so it doesn't seem worth it to fix the Makefiles.

zacklukem added a commit to zacklukem/rust that referenced this issue Apr 28, 2023
@zacklukem
Guarantee result nonzero for FFI
949e166 
Implements the required comipler changes for result_ffi_guarantees
(rust-lang#3391)

Allows `Result<T, E>` to be used in extern "C" functions where one of
(T, E) is a non-zero type and one of (T, E) is a zero sized type.
e.g. `Result<NonZeroI32, ()>`

Adds test cases to ensure that the abi for Result and Option types
with nonzero representation remains consistent
RalfJung pushed a commit to RalfJung/rust that referenced this issue Mar 23, 2024
@bors
Auto merge of rust-lang#3391 - RalfJung:dedup, r=RalfJung
67966f3 
remove duplicate test

This is basically the same as `tests/pass/imported_main.rs`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RonnyPfannschmidt @catamorphism @bstrie