Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all the maps implement a single trait or set of traits #3385

Closed
brson opened this issue Sep 4, 2012 · 2 comments
Closed

Make all the maps implement a single trait or set of traits #3385

brson opened this issue Sep 4, 2012 · 2 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone
0.6

Comments

@brson
Copy link
Contributor

brson commented Sep 4, 2012

HashMap, LinearMap, TreeMap, FunTreeMap, SmallIntMap. None of these things share traits.
@brson
Copy link
Contributor Author

brson commented Sep 5, 2012

oh SmallIntMap does implement Map

@dbp dbp mentioned this issue Oct 26, 2012
Closed
@catamorphism
Copy link
Contributor

We have core::container::Map now. HashMap is going away and @thestinger opened up a separate issue for SmallIntMap - #4693 So I'll close this.

RalfJung pushed a commit to RalfJung/rust that referenced this issue Mar 23, 2024
@bors
Auto merge of rust-lang#3385 - Zoxc:read-types, r=RalfJung
59b2945 
Report retags as distinct from real memory accesses for data races

This changes the error reporting for data races such that reference invariants are no longer reported as real read and writes.

Before:
```
Data race detected between (1) non-atomic write on thread `unnamed-6` and (2) non-atomic read on thread `unnamed-5` at alloc1034971+0x10c. (2) just happened here
```

After:
```
Data race detected between (1) non-atomic write on thread `unnamed-8` and (2) shared reference invariant on thread `unnamed-6` at alloc1018329+0x190. (2) just happened here
```

Non-atomic read accesses from the *other* thread don't have this information tracked so those are called `some potential non-atomic read access` here.
RenjiSann pushed a commit to RenjiSann/rust that referenced this issue Mar 25, 2024
@bors @RenjiSann
Auto merge of rust-lang#3385 - Zoxc:read-types, r=RalfJung
ecdd517 
Report retags as distinct from real memory accesses for data races

This changes the error reporting for data races such that reference invariants are no longer reported as real read and writes.

Before:
```
Data race detected between (1) non-atomic write on thread `unnamed-6` and (2) non-atomic read on thread `unnamed-5` at alloc1034971+0x10c. (2) just happened here
```

After:
```
Data race detected between (1) non-atomic write on thread `unnamed-8` and (2) shared reference invariant on thread `unnamed-6` at alloc1018329+0x190. (2) just happened here
```

Non-atomic read accesses from the *other* thread don't have this information tracked so those are called `some potential non-atomic read access` here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
2 participants
@brson @catamorphism