Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename main thread from "<main>" to "main" #33789

Closed
WiSaGaN opened this issue May 22, 2016 · 1 comment
Closed

Rename main thread from "<main>" to "main" #33789

WiSaGaN opened this issue May 22, 2016 · 1 comment
Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@WiSaGaN
Copy link
Contributor

WiSaGaN commented May 22, 2016

Currently the main thread is named "

". See playground.
As a result, other thread names have to be of style "" to be consistent in logs or other outputs.

Since we only have this one thread that is named by the system, "<>" does not help in distinguishing system threads with other threads.

"main" is simpler, and more consistent with what a name should be.

The change may affect program behaviour though, as the name of the main thread can be used to determine whether the current thread is main thread.
If the main thread name has not been specified in any way, this may be considered not a breaking change.

@WiSaGaN WiSaGaN changed the title Rename main thread name from "<main>" to "main" Rename main thread from "<main>" to "main" May 22, 2016
@huonw
Copy link
Member

huonw commented May 23, 2016

cc @rust-lang/libs

@huonw huonw added A-libs T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels May 23, 2016
bors added a commit that referenced this issue Jun 4, 2016
…hton

Rename main thread from "<main>" to "main".

Fix issue #33789

We may need to discuss whether this counts as a breaking change since code may check the main thread name against "\<main\>". Discussion is in #33789
@WiSaGaN WiSaGaN closed this as completed Jun 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants