Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid adding drops for types w/ no dtor in MIR construction #28159

Closed
nikomatsakis opened this issue Sep 1, 2015 · 0 comments
Closed

Avoid adding drops for types w/ no dtor in MIR construction #28159

nikomatsakis opened this issue Sep 1, 2015 · 0 comments
Labels
A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html

Comments

@nikomatsakis
Copy link
Contributor

The MIR code currently adds drops for all types that are not Copy, even if we can see that there is no destructor (e.g., struct Foo(u32)). This is relatively harmless (trans ignores such types) but it means more memory alloc etc than necessary. See associated FIXME.
@nikomatsakis nikomatsakis mentioned this issue Sep 1, 2015
Closed
16 tasks
@steveklabnik steveklabnik added the A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html label Sep 3, 2015
@wesleywiser wesleywiser mentioned this issue Dec 20, 2015
Merged
wesleywiser added a commit to wesleywiser/rust that referenced this issue Dec 31, 2015
@wesleywiser
Avoid adding drops for types w/ no dtor in MIR construction
8c897ee 
Fixes rust-lang#28159
bors added a commit that referenced this issue Jan 6, 2016
@bors
Auto merge of #30492 - wesleywiser:fix_extra_drops, r=pnkfelix
dc1f442 
Fixes #28159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steveklabnik @nikomatsakis