Tracking issue for `drain` stabilization #27711

aturon · 2015-08-12T17:45:38Z

The drain method was originally proposed in collections reform 2 and then adjusted in a follow-up RFC. The main remaining question for the API is the traits it uses to accept various kinds of ranges, which potentially interacts with inclusive ranges.

cc @bluss, who is working on an RFC to finish off this API.

The text was updated successfully, but these errors were encountered:

Gankra · 2015-08-12T17:53:40Z

Current opinion: stabilize Vec and HashMap with Vec using an unstable trait -- most just want to be able to call drain(..) and shouldn't care about the trait as long as it will always accept certain concrete args.

VecDeque is using the V1 API still (@mystor was working on this)

BTree needs serious work in relation to the range API

LinkedList is very "whatever" for me. drain is basically "doing it wrong" for LinkedList IMO. Typical concerns around indexing apply here, though. Ship has kinda sailed in the form of split_off.

bluss · 2015-08-12T20:28:54Z

My draft is https://gist.github.com/bluss/9b0f84fbb477de87d9d8 I'm just looking for comments before I post it.

@gankro It sounds like you favour a collections trait solution for this. It's a good solution for multidispatch reasons, but apart from that, I don't really have a guiding star for when we do collections traits (like Extend) and when we don't.

Gankra · 2015-08-13T01:39:11Z

This issue also tracks collections_range, whose only consumer and fate is Vec::drain. (VecDeque should also use it per #27723)

bluss · 2015-08-14T20:52:26Z

RFC: rust-lang/rfcs/pull/1257

aturon · 2015-11-03T23:55:10Z

Nominating for stabilization in 1.6. I'm not sure how much of the API surface here we want to stabilize, but note that it's fine to stabilize the drain method even while it references a currently-unstable trait.

Gankra · 2015-11-05T01:27:36Z

alexcrichton · 2015-11-05T17:46:02Z

🔔 This issue is now entering its cycle-long final comment period for stabilization 🔔

Note that the trait bound on the functions will not be included as part of the stabilization here, just the functions and return types.

alexcrichton · 2015-12-03T02:50:04Z

This was discussed in the libs team triage meeting today and the decision was to stabilize

This commit is the standard API stabilization commit for the 1.6 release cycle. The list of issues and APIs below have all been through their cycle-long FCP and the libs team decisions are listed below Stabilized APIs * `Read::read_exact` * `ErrorKind::UnexpectedEof` (renamed from `UnexpectedEOF`) * libcore -- this was a bit of a nuanced stabilization, the crate itself is now marked as `#[stable]` and the methods appearing via traits for primitives like `char` and `str` are now also marked as stable. Note that the extension traits themeselves are marked as unstable as they're imported via the prelude. The `try!` macro was also moved from the standard library into libcore to have the same interface. Otherwise the functions all have copied stability from the standard library now. * The `#![no_std]` attribute * `fs::DirBuilder` * `fs::DirBuilder::new` * `fs::DirBuilder::recursive` * `fs::DirBuilder::create` * `os::unix::fs::DirBuilderExt` * `os::unix::fs::DirBuilderExt::mode` * `vec::Drain` * `vec::Vec::drain` * `string::Drain` * `string::String::drain` * `vec_deque::Drain` * `vec_deque::VecDeque::drain` * `collections::hash_map::Drain` * `collections::hash_map::HashMap::drain` * `collections::hash_set::Drain` * `collections::hash_set::HashSet::drain` * `collections::binary_heap::Drain` * `collections::binary_heap::BinaryHeap::drain` * `Vec::extend_from_slice` (renamed from `push_all`) * `Mutex::get_mut` * `Mutex::into_inner` * `RwLock::get_mut` * `RwLock::into_inner` * `Iterator::min_by_key` (renamed from `min_by`) * `Iterator::max_by_key` (renamed from `max_by`) Deprecated APIs * `ErrorKind::UnexpectedEOF` (renamed to `UnexpectedEof`) * `OsString::from_bytes` * `OsStr::to_cstring` * `OsStr::to_bytes` * `fs::walk_dir` and `fs::WalkDir` * `path::Components::peek` * `slice::bytes::MutableByteVector` * `slice::bytes::copy_memory` * `Vec::push_all` (renamed to `extend_from_slice`) * `Duration::span` * `IpAddr` * `SocketAddr::ip` * `Read::tee` * `io::Tee` * `Write::broadcast` * `io::Broadcast` * `Iterator::min_by` (renamed to `min_by_key`) * `Iterator::max_by` (renamed to `max_by_key`) * `net::lookup_addr` New APIs (still unstable) * `<[T]>::sort_by_key` (added to mirror `min_by_key`) Closes rust-lang#27585 Closes rust-lang#27704 Closes rust-lang#27707 Closes rust-lang#27710 Closes rust-lang#27711 Closes rust-lang#27727 Closes rust-lang#27740 Closes rust-lang#27744 Closes rust-lang#27799 Closes rust-lang#27801 cc rust-lang#27801 (doesn't close as `Chars` is still unstable) Closes rust-lang#28968

This commit is the standard API stabilization commit for the 1.6 release cycle. The list of issues and APIs below have all been through their cycle-long FCP and the libs team decisions are listed below Stabilized APIs * `Read::read_exact` * `ErrorKind::UnexpectedEof` (renamed from `UnexpectedEOF`) * libcore -- this was a bit of a nuanced stabilization, the crate itself is now marked as `#[stable]` and the methods appearing via traits for primitives like `char` and `str` are now also marked as stable. Note that the extension traits themeselves are marked as unstable as they're imported via the prelude. The `try!` macro was also moved from the standard library into libcore to have the same interface. Otherwise the functions all have copied stability from the standard library now. * `fs::DirBuilder` * `fs::DirBuilder::new` * `fs::DirBuilder::recursive` * `fs::DirBuilder::create` * `os::unix::fs::DirBuilderExt` * `os::unix::fs::DirBuilderExt::mode` * `vec::Drain` * `vec::Vec::drain` * `string::Drain` * `string::String::drain` * `vec_deque::Drain` * `vec_deque::VecDeque::drain` * `collections::hash_map::Drain` * `collections::hash_map::HashMap::drain` * `collections::hash_set::Drain` * `collections::hash_set::HashSet::drain` * `collections::binary_heap::Drain` * `collections::binary_heap::BinaryHeap::drain` * `Vec::extend_from_slice` (renamed from `push_all`) * `Mutex::get_mut` * `Mutex::into_inner` * `RwLock::get_mut` * `RwLock::into_inner` * `Iterator::min_by_key` (renamed from `min_by`) * `Iterator::max_by_key` (renamed from `max_by`) Deprecated APIs * `ErrorKind::UnexpectedEOF` (renamed to `UnexpectedEof`) * `OsString::from_bytes` * `OsStr::to_cstring` * `OsStr::to_bytes` * `fs::walk_dir` and `fs::WalkDir` * `path::Components::peek` * `slice::bytes::MutableByteVector` * `slice::bytes::copy_memory` * `Vec::push_all` (renamed to `extend_from_slice`) * `Duration::span` * `IpAddr` * `SocketAddr::ip` * `Read::tee` * `io::Tee` * `Write::broadcast` * `io::Broadcast` * `Iterator::min_by` (renamed to `min_by_key`) * `Iterator::max_by` (renamed to `max_by_key`) * `net::lookup_addr` New APIs (still unstable) * `<[T]>::sort_by_key` (added to mirror `min_by_key`) Closes #27585 Closes #27704 Closes #27707 Closes #27710 Closes #27711 Closes #27727 Closes #27740 Closes #27744 Closes #27799 Closes #27801 cc #27801 (doesn't close as `Chars` is still unstable) Closes #28968

durka · 2016-01-13T18:02:15Z

I noticed this is closed since drain got stabilized, but collections_range (i.e. RangeArgument) is still unstable. Should this be reopened or is a separate tracking issue best?

alexcrichton · 2016-01-13T18:39:28Z

@durka yeah we should likely open a new issue for that

durka · 2016-01-13T18:43:10Z

Okay, will do!

On Wed, Jan 13, 2016 at 1:40 PM, Alex Crichton [email protected]
wrote:

@durka https://github.com/durka yeah we should likely open a new issue
for that

—
Reply to this email directly or view it on GitHub
#27711 (comment).

@alexcrichton

…sue, r=nagisa see rust-lang#27711 and rust-lang#30877 r? @alexcrichton

aturon added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. B-unstable Blocker: Implemented in the nightly compiler and unstable. labels Aug 12, 2015

Ms2ger mentioned this issue Aug 16, 2015

Tracking: Unstable Rust feature gates used by Servo servo/servo#5286

Closed

99 tasks

alexcrichton mentioned this issue Oct 15, 2015

RFC: .drain(range) and .drain() rust-lang/rfcs#1257

Merged

aturon added the I-nominated label Nov 3, 2015

alexcrichton added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed I-nominated labels Nov 5, 2015

alexcrichton mentioned this issue Dec 3, 2015

std: Stabilize APIs for the 1.6 release #30187

Merged

bors closed this as completed in #30187 Dec 6, 2015

This was referenced Jan 13, 2016

Tracking issue for RangeBounds #30877

Closed

update tracking issue for collections_range #30879

Merged

Manishearth added a commit to Manishearth/rust that referenced this issue Jan 14, 2016

Rollup merge of rust-lang#30879 - durka:collections-range-tracking-is…

f28a431

…sue, r=nagisa see rust-lang#27711 and rust-lang#30877 r? @alexcrichton

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tracking issue for `drain` stabilization #27711

Tracking issue for `drain` stabilization #27711

aturon commented Aug 12, 2015

Gankra commented Aug 12, 2015

bluss commented Aug 12, 2015

Gankra commented Aug 13, 2015

bluss commented Aug 14, 2015

aturon commented Nov 3, 2015

Gankra commented Nov 5, 2015

alexcrichton commented Nov 5, 2015

alexcrichton commented Dec 3, 2015

durka commented Jan 13, 2016

alexcrichton commented Jan 13, 2016

durka commented Jan 13, 2016

Tracking issue for drain stabilization #27711

Tracking issue for drain stabilization #27711

Comments

aturon commented Aug 12, 2015

Gankra commented Aug 12, 2015

bluss commented Aug 12, 2015

Gankra commented Aug 13, 2015

bluss commented Aug 14, 2015

aturon commented Nov 3, 2015

Gankra commented Nov 5, 2015

alexcrichton commented Nov 5, 2015

alexcrichton commented Dec 3, 2015

durka commented Jan 13, 2016

alexcrichton commented Jan 13, 2016

durka commented Jan 13, 2016

Tracking issue for `drain` stabilization #27711

Tracking issue for `drain` stabilization #27711