Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate various "make sure these two types are the same" functions in typeck #2644

Closed
lkuper opened this issue Jun 20, 2012 · 1 comment
Closed

Consolidate various "make sure these two types are the same" functions in typeck #2644

lkuper opened this issue Jun 20, 2012 · 1 comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone
old 1.0 milestone

Comments

@lkuper
Copy link
Contributor

lkuper commented Jun 20, 2012

There are a litany of "make sure these two types are the same" functions in various places in typeck (require_same_types, require_same_types_in_infcx, are_compatible, compare_tys), some of which are only used in one place. We should consolidate these.
@ghost ghost assigned lkuper Jun 20, 2012
lkuper added a commit that referenced this issue Jun 21, 2012
@lkuper
Consolidate "make sure types are the same" fns. Issue #2644.
e9d072e
@lkuper
Copy link
Contributor Author

lkuper commented Jun 21, 2012

e9d072e closes this.

@lkuper lkuper closed this as completed Jun 21, 2012
@lkuper lkuper removed their assignment Jun 16, 2014
RalfJung pushed a commit to RalfJung/rust that referenced this issue Dec 24, 2022
@bors
Auto merge of rust-lang#2721 - a-b-c-1-2-3:fix-pagesize, r=RalfJung
f2ae9e5 
Allow configurable and platform-specific page sizes

This fixes rust-lang#2644 by setting platform-default page sizes along with a command line flag to override size to a specific value (e.g. in the case of aarch64 Linux on M1 silicon). There's still some code cleanup to be done and tests need to be added but I'm opening this for now.
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
@bors
Auto merge of rust-lang#2721 - a-b-c-1-2-3:fix-pagesize, r=RalfJung
0805372 
Allow configurable and platform-specific page sizes

This fixes rust-lang#2644 by setting platform-default page sizes along with a command line flag to override size to a specific value (e.g. in the case of aarch64 Linux on M1 silicon). There's still some code cleanup to be done and tests need to be added but I'm opening this for now.
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@feliperodri
Include temporary test files to gitgnore (rust-lang#2644)
06f0b5c 
Signed-off-by: Felipe R. Monteiro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
old 1.0 milestone
Development

No branches or pull requests
1 participant
@lkuper