-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a --test-threads option for rustc test binaries #25636
Comments
Agreed. |
The ability to specify this in the |
It is already set table by an env var, no? Cargo just can't specify them. So still not ideal but might work in the meantime. On Apr 16, 2016, 19:05 -0400, Nathan [email protected], wrote:
|
@steveklabnik Oh cool thanks, I'll set that in my project. |
This change allows parallelism of test runs to be specified by a command line flag names --test-threads in addition to the existing environment variable RUST_TEST_THREADS. Fixes rust-lang#25636.
…=alexcrichton Add --test-threads option to test binaries This change allows parallelism of test runs to be specified by a command line flag names --test-threads in addition to the existing environment variable RUST_TEST_THREADS. Fixes rust-lang#25636.
Add --test-threads option to test binaries This change allows parallelism of test runs to be specified by a command line flag names --test-threads in addition to the existing environment variable RUST_TEST_THREADS. Fixes #25636.
Discussion carried over from: rust-lang/cargo#1591
Test binaries created by rustc should have a
--test-threads
option instead of (in addition to?) controlling the thread count withRUST_TEST_THREADS
. It's not a consistent user experience to have some functionality controlled via environment variables and some via command line options. CLI options should be preferred since they encourage users to keep configuration local to a single execution of a test binary and not export it globally, making it affect other test runs perhaps accidentally. It would also make the output oftest_binary -h
more uniform and compact.The text was updated successfully, but these errors were encountered: