Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking RFC 430 - conform to naming conventions #19091

Closed
brson opened this issue Nov 18, 2014 · 1 comment
Closed

Tracking RFC 430 - conform to naming conventions #19091

brson opened this issue Nov 18, 2014 · 1 comment
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.

Comments

@brson
Copy link
Contributor

brson commented Nov 18, 2014

Tracking rust-lang/rfcs#430

cc @aturon
@brson brson added the B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. label Nov 18, 2014
@brson brson mentioned this issue Nov 18, 2014
Closed
@alexcrichton alexcrichton mentioned this issue Nov 20, 2014
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this issue Nov 22, 2014
@alexcrichton
Rename unwrap functions to into_inner
6f88f8d 
This change applies the conventions to unwrap listed in [RFC 430][rfc] to rename
non-failing `unwrap` methods to `into_inner`. This is a breaking change, but all
`unwrap` methods are retained as `#[deprecated]` for the near future. To update
code rename `unwrap` method calls to `into_inner`.

[rfc]: rust-lang/rfcs#430
[breaking-change]

Closes rust-lang#13159
cc rust-lang#19091
alexcrichton added a commit to alexcrichton/rust that referenced this issue Nov 23, 2014
@alexcrichton
Rename unwrap functions to into_inner
f1f6c12 
This change applies the conventions to unwrap listed in [RFC 430][rfc] to rename
non-failing `unwrap` methods to `into_inner`. This is a breaking change, but all
`unwrap` methods are retained as `#[deprecated]` for the near future. To update
code rename `unwrap` method calls to `into_inner`.

[rfc]: rust-lang/rfcs#430
[breaking-change]

Closes rust-lang#13159
cc rust-lang#19091
bors added a commit that referenced this issue Nov 25, 2014
@bors
auto merge of #19149 : alexcrichton/rust/issue-19091, r=aturon
f6cb58c 
This change applies the conventions to unwrap listed in [RFC 430][rfc] to rename
non-failing `unwrap` methods to `into_inner`. This is a breaking change, but all
`unwrap` methods are retained as `#[deprecated]` for the near future. To update
code rename `unwrap` method calls to `into_inner`.

[rfc]: rust-lang/rfcs#430
[breaking-change]

cc #19091
@alexcrichton
Copy link
Member

I believe this has largely been applied throughout the libraries (primarily the unwrap => into_inner) change. Closing as the few stragglers (if any) should crop up during normal stabilization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @brson