Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guide: guessing game promises number of guesses, but fails to deliver #17964

Closed
jkleint opened this issue Oct 12, 2014 · 2 comments
Closed

Guide: guessing game promises number of guesses, but fails to deliver #17964

jkleint opened this issue Oct 12, 2014 · 2 comments

Comments

@jkleint
Copy link

jkleint commented Oct 12, 2014

O, the heartbreak! ;)

https://github.com/rust-lang/rust/blame/master/src/doc/guide.md#L1749

@steveklabnik, not sure if you want to add a counter or remove the promise.
@steveklabnik
Copy link
Member

Either works. I've done both versions. Probably just remove the promise.

jkleint pushed a commit to jkleint/rust that referenced this issue Oct 12, 2014
Guide: remove promise of a counter in the guessing game.
67418f5 
Issue rust-lang#17964.
@jkleint jkleint mentioned this issue Oct 12, 2014
Merged
@alexcrichton
Copy link
Member

Closed by #17979

lnicola pushed a commit to lnicola/rust that referenced this issue Aug 29, 2024
@bors
Auto merge of rust-lang#17970 - ChayimFriedman2:unwrap-unsafe-block, …
6593688 
…r=Veykril

fix: Fix "Unwrap block" assist with block modifiers

The assist just assumes the `{` will be the first character, which led to strange outputs such as `nsafe {`.

Fixes rust-lang#17964.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steveklabnik @alexcrichton @jkleint