Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul the #[cfg(..)] pattern syntax #17490

Closed
alexcrichton opened this issue Sep 23, 2014 · 3 comments · Fixed by #17630
Closed

Overhaul the #[cfg(..)] pattern syntax #17490

alexcrichton opened this issue Sep 23, 2014 · 3 comments · Fixed by #17630
Assignees
@sfackler
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.
Milestone
1.0

Comments

@alexcrichton
Copy link
Member

Tracking issue for rust-lang/rfcs#194.

Nominating as the changes are backwards-incompatible.
@alexcrichton alexcrichton added I-nominated B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. labels Sep 23, 2014
@alexcrichton
Copy link
Member Author

Assigning to @sfackler who has volunteered to implement.

This was referenced Sep 24, 2014
Merged
Merged
@pnkfelix pnkfelix mentioned this issue Sep 25, 2014
Closed
@pnkfelix
Copy link
Member

1.0, P-backcompat-lang.

@pnkfelix pnkfelix added this to the 1.0 milestone Sep 25, 2014
bors added a commit that referenced this issue Sep 27, 2014
@bors
auto merge of #17506 : sfackler/rust/cfg-attr, r=alexcrichton
43d7d7c 
cc #17490 

Reopening of #16230
bors added a commit that referenced this issue Sep 28, 2014
@bors
auto merge of #17527 : sfackler/rust/cfg-syntax, r=alexcrichton
7eb9337 
We'll need a snapshot before we can convert the codebase over and turn on the deprecation warnings.

cc #17490

This is sitting on top of #17506
@pcwalton
Copy link
Contributor

Blocked on a snapshot.

@sfackler sfackler mentioned this issue Sep 29, 2014
Merged
bors added a commit that referenced this issue Oct 1, 2014
@bors
auto merge of #17630 : sfackler/rust/cfg-warnings, r=brson
ff2616e 
Closes #17490
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfackler sfackler

Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Turn on warnings for legacy cfg syntax and convert the stdlib sfackler/rust
4 participants
@alexcrichton @pcwalton @pnkfelix @sfackler