Static libs are doubling up on new lang item definitions

[bharrisau]

Since #14293 I have added the dummy lang items for the weak linking in my projects (or I am unable to build static libs). Now static libs are defining rust_eh_personality and rust_stack_exhausted which is causing linker errors due to duplicate definitions.

Note: This is only for static libs, rlibs are fine. See travis log here https://travis-ci.org/bharrisau/zinc/jobs/25774156

[huonw]

cc @alexcrichton (thanks for filing!)

[alexcrichton]

The staticlib format was initially intended to be the only compilation unit of rust included in an external product. Including two staticlibs was not an intended use case of staticlibs (hence the duplicated symbols). Each staticlib output is inteded to be its own standalone version of the rust world necessary for it to run.

Could you combine the two staticlibs into one staticlib with a meta-crate?

[bharrisau]

Probably (im not the primary maintainer). Don't mind if this is
#willnotfix, I was just making sure there was awareness of the change.
On 23/05/2014 1:03 am, "Alex Crichton" notifications@github.com wrote:

The staticlib format was initially intended to be the only compilation
unit of rust included in an external product. Including two staticlibs was
not an intended use case of staticlibs (hence the duplicated symbols). Each
staticlib output is inteded to be its own standalone version of the rust
world necessary for it to run.

Could you combine the two staticlibs into one staticlib with a meta-crate?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/14355#issuecomment-43915887
.

[alexcrichton]

Ok, for now I'm going to close this as WONTFIX and instead recommend only one staticlib being included at a time. We may want to revisit that decision later, but for now that's the state of things.