std::io::net may need more thought #13537
Comments
|
Does I guess this is me agreeing that there should be a top level |
|
And |
|
|
|
I believe that with the "libstd facade" that I do think that a "libstd facade" will make implementing |
|
Marking P-high, not 1.0 milestone. Specific bugs can/should be opened if there are particular items that you want to assign higher priority (i.e. want to get them on the 1.0 milestone). |
…en, r=alexcrichton Been meaning to try my hand at something like this for a while, and noticed something similar mentioned as part of #13537. The suggestion on the original ticket is to use `TcpStream::open(&str)` to pass in a host + port string, but seems a little cleaner to pass in host and port separately -- so a signature like `TcpStream::open(&str, u16)`. Also means we can use std::io::net::addrinfo directly instead of using e.g. liburl to parse the host+port pair from a string. One outstanding issue in this PR that I'm not entirely sure how to address: in open_timeout, the timeout_ms will apply for every A record we find associated with a hostname -- probably not the intended behavior, but I didn't want to waste my time on elaborate alternatives until the general idea was a-OKed. :) Anyway, perhaps there are other reasons for us to prefer the original proposed syntax, but thought I'd get some thoughts on this. Maybe there are some solid reasons to prefer using liburl to do this stuff.
…en, r=alexcrichton Been meaning to try my hand at something like this for a while, and noticed something similar mentioned as part of #13537. The suggestion on the original ticket is to use `TcpStream::open(&str)` to pass in a host + port string, but seems a little cleaner to pass in host and port separately -- so a signature like `TcpStream::open(&str, u16)`. Also means we can use std::io::net::addrinfo directly instead of using e.g. liburl to parse the host+port pair from a string. One outstanding issue in this PR that I'm not entirely sure how to address: in open_timeout, the timeout_ms will apply for every A record we find associated with a hostname -- probably not the intended behavior, but I didn't want to waste my time on elaborate alternatives until the general idea was a-OKed. :) Anyway, perhaps there are other reasons for us to prefer the original proposed syntax, but thought I'd get some thoughts on this. Maybe there are some solid reasons to prefer using liburl to do this stuff.
|
Seems like this issue has bitrotted. |
minor: Allow ovsx publishing to fail
Mark unnecessary_first_then_check and byte_char_slices as Applicable I don't really see situations where this isn't Applicable that aren't weird edge cases where the lint should be disabled. changelog: none
The
netmodule has a few things which I would like to consider improving:AcceptorandListenertraits exists? It's a shame having to import the traits just to make a simple server.std::io::net::ipis quite long. Possibly a top-levelnetmodule? Possibly shorten using reexports?Wish list
TcpStream::open("google.com:80")does not workNominating, I believe it is quite important to have a solid networking story.
The text was updated successfully, but these errors were encountered: