Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new attribute syntax everywhere #13478

Closed
Manishearth opened this issue Apr 12, 2014 · 5 comments
Closed

Use new attribute syntax everywhere #13478

Manishearth opened this issue Apr 12, 2014 · 5 comments

Comments

@Manishearth
Copy link
Member

#2569 changes inner attribute syntax. While solving #13476 I realized that there were a lot more occurrences of the old syntax throughout the repo. I guess these should be fixed.
@Manishearth
Copy link
Member Author

The above commits were generated with sed, so I'm not entirely sure if they are valid.

@Manishearth
Copy link
Member Author

Not yet PRing since this is based on #13477

@huonw
Copy link
Member

huonw commented Apr 13, 2014

Feel free to submit a PR with the commits from #13477 included, iirc Github will automatically drop them from the diff if that PR lands first (and if the new PR lands first then... both sets of features have landed).

@Manishearth Manishearth mentioned this issue Apr 13, 2014
Merged
@Manishearth
Copy link
Member Author

Alright. It still says that the branches can't be automerged, but that shouldn't be a big issue i guess. Filed #13493

Manishearth added a commit to Manishearth/rust that referenced this issue Apr 14, 2014
@Manishearth
Use new attribute syntax in python files in src/etc too (rust-lang#13478
713e875 
)
bors added a commit that referenced this issue Apr 14, 2014
@bors
auto merge of #13493 : Manishearth/rust/newattr-everywhere, r=alexcri…
246ebd2 
…chton

See #13478
@steveklabnik
Copy link
Member

With #13493 merged, I'm closing.

Dylan-DPC pushed a commit to Dylan-DPC/rust that referenced this issue Nov 1, 2022
@bors
Auto merge of rust-lang#13478 - Veykril:fix-flycheck, r=Veykril
53b6d69 
fix: Fix standard flycheck command not being executed in the workspace it is being invoked for

Fixes rust-lang/rust-analyzer#13477
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steveklabnik @huonw @Manishearth