-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: native builds broken on s390x #133177
Comments
Does adding an rust/library/core/src/panic.rs Line 218 in c00d642
|
Yes, it does! With that change the native build completes successfully again. |
s390x-unknown-linux-gnu is a Tier 2 With Host Tools target, so it should not have been possible for this breakage to merge. @uweigand You are reporting this as a native build failure. I can of course compile a sysroot with |
Yes, I also assume this may be a difference between native builds and cross-builds. Do you generally perform native builds for the whole set of supported architectures (even just the Tier 2 With Host Tools ones)? As to access to a s390x host for test purposes, there are various options; I'd recommend one of the following:
In addition, we're currently investigating options of making native s390x builds more directly available via GitHub actions (without you having to set up and manage the host yourself), but that is not yet available today. |
We could add a |
Btw @uweigand if IBM could help maintain the s390x LLVM backend, e.g. by fixing selection issues like this, that'd be great. :D |
Yes, of course. We're already working on adding fp16 support to LLVM (and GCC as well): llvm/llvm-project#109164 This should hopefully be available in LLVM 20. For any other LLVM issues on s390x always feel free to contact me. |
…oss35 const_panic: inline in bootstrap builds to avoid f16/f128 crashes This should fix rust-lang#133177. `@uweigand` could you test that?
Rollup merge of rust-lang#133182 - RalfJung:const-panic-inline, r=tgross35 const_panic: inline in bootstrap builds to avoid f16/f128 crashes This should fix rust-lang#133177. ``@uweigand`` could you test that?
Bit of an aside but this sort of thing would be awesome to have in the dev guide, I had no idea these were available but this is great for figuring out test failures. |
I submitted the resource request. I'm not sure whether it is per-user or for the entire organization, but if it is for the org then maybe we can wire it up to our dev desktops somehow (https://forge.rust-lang.org/infra/docs/dev-desktop.html, https://github.com/rust-lang/simpleinfra/tree/master/ansible/roles/dev-desktop) |
I've now opened #133577 .
This is a (virtual) machine where you have full root access, so you can set this up as you like; as long as ensure the machine will only be accessed and used for the intended purpose (i.e. development of the Rust compiler and open-source ecosystem). |
After #133050 was merged, all native builds on s390x fail very early during stage0 library build:
Specifically, it looks like the problem was introduced by commit b77dbbd, which adds passing of an argument of type
f16
by value.The text was updated successfully, but these errors were encountered: