Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x test mir-opt --bless tries to checkout src/llvm-project #130906

Closed
saethlin opened this issue Sep 26, 2024 · 0 comments · Fixed by #130918
Closed

x test mir-opt --bless tries to checkout src/llvm-project #130906

saethlin opened this issue Sep 26, 2024 · 0 comments · Fixed by #130918
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@saethlin
Copy link
Member

I tracked this down to this call, which tries to checkout the LLVM submodule, even if I have download-ci-llvm = true specifically because I do not want the submodule checked out:

if crate::core::build_steps::llvm::prebuilt_llvm_config(self, target).should_build() {

Here's my config, but I doubt it matters:

change-id = 999999

[llvm]
#assertions = false
download-ci-llvm = true

#[build]
#submodules = true

[rust]
codegen-backends = ["llvm"]
new-symbol-mangling = false
frame-pointers = true
deny-warnings = false
use-lld = true
incremental = false
debuginfo-level-std = 2
debuginfo-level = 1
debug = false
debug-logging = false
@saethlin saethlin added C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 26, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 26, 2024
@onur-ozkan onur-ozkan removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 27, 2024
@bors bors closed this as completed in f33fa3f Sep 28, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Sep 28, 2024
Rollup merge of rust-lang#130918 - onur-ozkan:better-llvm-submodule-handling, r=Kobzol

simplify LLVM submodule handling

Fixes rust-lang#130906.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants