Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pin_ergonomics] Allow reborrowing Pin<&mut T> without the value being in a mutable place #130535

Closed
eholk opened this issue Sep 18, 2024 · 1 comment
Closed

[pin_ergonomics] Allow reborrowing Pin<&mut T> without the value being in a mutable place #130535

eholk opened this issue Sep 18, 2024 · 1 comment
Labels
C-bug Category: This is a bug. F-pin_ergonomics `#![feature(pin_ergonomics)]` T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@eholk
Copy link
Contributor

eholk commented Sep 18, 2024

This issue came up in code review for #130526. Here's the comment in question:

#130526 (comment)
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 18, 2024
@eholk eholk mentioned this issue Sep 18, 2024
Merged
@jieyouxu jieyouxu added T-lang Relevant to the language team, which will review and decide on the PR/issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-bug Category: This is a bug. F-pin_ergonomics `#![feature(pin_ergonomics)]` and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Sep 19, 2024
@eholk
Copy link
Contributor Author

eholk commented Sep 19, 2024

Fixed during code review.

@eholk eholk closed this as completed Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. F-pin_ergonomics `#![feature(pin_ergonomics)]` T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eholk @jieyouxu @rustbot