Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rustdoc-json] Regression — core.json, alloc.json and std.json are no longer available on nightly for rust-docs-json component #128610

Closed
LukeMathWalker opened this issue Aug 3, 2024 · 2 comments · Fixed by #128631
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@LukeMathWalker
Copy link
Contributor

LukeMathWalker commented Aug 3, 2024

I have pinned down the regression to a specific commit, thanks to @aDotInTheVoid recommending me cargo-bisect-rustc.

Output of cargo bisect-rustc

searched nightlies: from nightly-2024-07-28 to nightly-2024-07-30
regressed nightly: nightly-2024-07-30
searched commit range: 2cbbe8b...612a33f
regressed commit: 56c698c

bisected with cargo-bisect-rustc v0.6.9

Host triple: aarch64-apple-darwin
Reproduce with:

cargo bisect-rustc -c rust-docs-json --start=2024-07-28 --end=2024-07-30 --script ./regr.sh

regr.sh:

#!/bin/sh
set -ex

if [ ! -f ~/.rustup/toolchains/${RUSTUP_TOOLCHAIN}/share/doc/rust/json/core.json ]; then
    echo "File not found!"
    exit 1
fi
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 3, 2024
@LukeMathWalker
Copy link
Contributor Author

Based on the commits in that rollup, I feel like #128182 might be the culprit, but it isn't obvious to me why that might be the case (cc @onur-ozkan, @ChrisDenton, @Mark-Simulacrum)

@jieyouxu jieyouxu added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. regression-untriaged Untriaged performance or correctness regression. labels Aug 4, 2024
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Aug 4, 2024
@onur-ozkan onur-ozkan removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 4, 2024
@onur-ozkan
Copy link
Member

Thanks for the ping, #128631 will fix this.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 4, 2024
handle crates when they are not specified for std docs

Fixes a regression from rust-lang#128182.

Resolves rust-lang#128610
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 4, 2024
handle crates when they are not specified for std docs

Fixes a regression from rust-lang#128182.

Resolves rust-lang#128610
@apiraino apiraino removed the regression-untriaged Untriaged performance or correctness regression. label Aug 5, 2024
@bors bors closed this as completed in 9d924d1 Aug 5, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Aug 5, 2024
Rollup merge of rust-lang#128631 - onur-ozkan:hotfix, r=Mark-Simulacrum

handle crates when they are not specified for std docs

Fixes a regression from rust-lang#128182.

Resolves rust-lang#128610
@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants