Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rustc dependency on libextra #12413

Closed
HeroesGrave opened this issue Feb 20, 2014 · 3 comments · Fixed by #12896
Closed

Remove rustc dependency on libextra #12413

HeroesGrave opened this issue Feb 20, 2014 · 3 comments · Fixed by #12896

Comments

@HeroesGrave
Copy link
Contributor

To help with #8784.

The following parts of libextra would need to be moved:
@edwardw
Copy link
Contributor

edwardw commented Feb 21, 2014

Well, #12387 just added a dependency to extra in rustc.

@HeroesGrave
Copy link
Contributor Author

I think there was a plan to move json out to libserialize.

@darnuria
Copy link
Contributor

Yep that's this pull request : #12453

@alexcrichton alexcrichton mentioned this issue Mar 14, 2014
Merged
bors added a commit that referenced this issue Mar 15, 2014
@bors
auto merge of #12896 : alexcrichton/rust/goodbye-extra, r=brson
fc7a112 
This commit shreds all remnants of libextra from the compiler and standard
distribution. Two modules, c_vec/tempfile, were moved into libstd after some
cleanup, and the other modules were moved to separate crates as seen fit.

Closes #8784
Closes #12413
Closes #12576
flip1995 pushed a commit to flip1995/rust that referenced this issue Mar 7, 2024
@bors
Auto merge of rust-lang#12413 - high-cloud:fix_assign_ops2, r=flip1995
2d9d404 
[`misrefactored_assign_op`]: Fix duplicate diagnostics

Relate to rust-lang#12379

The following diagnostics appear twice
```
  --> tests/ui/assign_ops2.rs:26:5
   |
LL |     a *= a * a;
   |     ^^^^^^^^^^
   |
help: did you mean `a = a * a` or `a = a * a * a`? Consider replacing it with
```

because `a` (lhs) appears in both left operand and right operand in the right hand side.
This PR fixes the issue so that if a diagnostic is created for an operand, the check of the other operand will be skipped. It's fine because the result is always the same in the affected operators.

changelog: [`misrefactored_assign_op`]: Fix duplicate diagnostics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

extra: Put the nail in the coffin, delete libextra alexcrichton/rust
3 participants
@edwardw @HeroesGrave @darnuria