Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for feature(ub_checks) and -Zub-checks #123499

Open
1 of 3 tasks
saethlin opened this issue Apr 5, 2024 · 0 comments
Open
1 of 3 tasks

Tracking Issue for feature(ub_checks) and -Zub-checks #123499

saethlin opened this issue Apr 5, 2024 · 0 comments
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC

Comments

@saethlin
Copy link
Member

saethlin commented Apr 5, 2024

The feature gate for the issue is #![feature(ub_checks)].

It allows write code that detects if the compiler will emit UB checks, simlar to how `cfg(debug_assertions) detects if debug assertions are enabled.

We also track the -Zub-checks flag here; that should eventually become -Cub-checks similar to -Coverflow-checks.

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved Questions

Implementation history

#123411

@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Apr 5, 2024
@saethlin saethlin added C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Apr 5, 2024
@RalfJung RalfJung changed the title Tracking Issue for cfg(ub_checks) Tracking Issue for feature(ub_checks) and -Zub-checks Apr 8, 2024
ShadowCurse added a commit to ShadowCurse/firecracker that referenced this issue Nov 28, 2024
We need to do this because we have tests which create
Files from a raw fds or do an explicit close on fds.
This causes UB check to trigger and test to panic.
There is no separate flag to disable these checks,
so we have to disable all debug-assertions in test builds.
Tracking issue: rust-lang/rust#123499

Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse added a commit to ShadowCurse/firecracker that referenced this issue Nov 28, 2024
We need to do this because we have tests which create
Files from a raw fds or do an explicit close on fds.
This causes UB check to trigger and test to panic.
There is no separate flag to disable these checks,
so we have to disable all debug-assertions in test builds.
Tracking issue: rust-lang/rust#123499

Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse added a commit to ShadowCurse/firecracker that referenced this issue Nov 28, 2024
We need to do this because we have tests which create
Files from a raw fds or do an explicit close on fds.
This causes UB check to trigger and test to panic.
There is no separate flag to disable these checks,
so we have to disable all debug-assertions in test builds.
Tracking issue: rust-lang/rust#123499

Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse added a commit to ShadowCurse/firecracker that referenced this issue Nov 28, 2024
We need to do this because we have tests which create
Files from a raw fds or do an explicit close on fds.
This causes UB check to trigger and test to panic.
There is no separate flag to disable these checks,
so we have to disable all debug-assertions in test builds.
Tracking issue: rust-lang/rust#123499

Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse added a commit to ShadowCurse/firecracker that referenced this issue Nov 28, 2024
We need to do this because we have tests which create
Files from a raw fds or do an explicit close on fds.
This causes UB check to trigger and test to panic.
There is no separate flag to disable these checks,
so we have to disable all debug-assertions in test builds.
Tracking issue: rust-lang/rust#123499

Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse added a commit to ShadowCurse/firecracker that referenced this issue Nov 28, 2024
We need to do this because we have tests which create
Files from a raw fds or do an explicit close on fds.
This causes UB check to trigger and test to panic.
There is no separate flag to disable these checks,
so we have to disable all debug-assertions in test builds.
Tracking issue: rust-lang/rust#123499

Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse added a commit to ShadowCurse/firecracker that referenced this issue Nov 29, 2024
We need to do this because we have tests which create
Files from a raw fds or do an explicit close on fds.
This causes UB check to trigger and test to panic.
There is no separate flag to disable these checks,
so we have to disable all debug-assertions in test builds.
Tracking issue: rust-lang/rust#123499

Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse added a commit to ShadowCurse/firecracker that referenced this issue Nov 29, 2024
We need to do this because we have tests which create
Files from a raw fds or do an explicit close on fds.
This causes UB check to trigger and test to panic.
There is no separate flag to disable these checks,
so we have to disable all debug-assertions in test builds.
Tracking issue: rust-lang/rust#123499

Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse added a commit to ShadowCurse/firecracker that referenced this issue Nov 29, 2024
We need to do this because we have tests which create
Files from a raw fds or do an explicit close on fds.
This causes UB check to trigger and test to panic.
There is no separate flag to disable these checks,
so we have to disable all debug-assertions in test builds.
Tracking issue: rust-lang/rust#123499

Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse added a commit to ShadowCurse/firecracker that referenced this issue Nov 29, 2024
We need to do this because we have tests which create
Files from a raw fds or do an explicit close on fds.
This causes UB check to trigger and test to panic.
There is no separate flag to disable these checks,
so we have to disable all debug-assertions in test builds.
Tracking issue: rust-lang/rust#123499

Signed-off-by: Egor Lazarchuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC
Projects
None yet
Development

No branches or pull requests

2 participants