-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve MSVC debug info for f16 and f128 #121837
Labels
A-debuginfo
Area: Debugging information in compiled programs (DWARF, PDB, etc.)
E-hard
Call for participation: Hard difficulty. Experience needed to fix: A lot.
E-needs-investigation
Call for partcipation: This issues needs some investigation to determine current status
F-f16_and_f128
`#![feature(f16)]`, `#![feature(f128)]`
O-windows-msvc
Toolchain: MSVC, Operating system: Windows
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
WG-debugging
Working group: Bad Rust debugging experiences
Comments
rustbot
added
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
F-f16_and_f128
`#![feature(f16)]`, `#![feature(f128)]`
labels
Mar 1, 2024
@rustbot label +A-debuginfo +O-windows-msvc +T-compiler -needs-triage +E-easy |
This comment has been minimized.
This comment has been minimized.
rustbot
added
A-debuginfo
Area: Debugging information in compiled programs (DWARF, PDB, etc.)
O-windows-msvc
Toolchain: MSVC, Operating system: Windows
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
and removed
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
labels
Mar 1, 2024
85 tasks
rustbot
added
the
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
label
May 16, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jul 5, 2024
…rister Add Natvis visualiser and debuginfo tests for `f16` To render `f16`s in debuggers on MSVC targets, this PR changes the compiler to output `f16`s as `struct f16 { bits: u16 }`, and includes a Natvis visualiser that manually converts the `f16`'s bits to a `float` which is can then be displayed by debuggers. `gdb`, `lldb` and `cdb` tests are also included for `f16` . `f16`/`f128` MSVC debug info issue: rust-lang#121837 Tracking issue: rust-lang#116909
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jul 8, 2024
…rister Add Natvis visualiser and debuginfo tests for `f16` To render `f16`s in debuggers on MSVC targets, this PR changes the compiler to output `f16`s as `struct f16 { bits: u16 }`, and includes a Natvis visualiser that manually converts the `f16`'s bits to a `float` which is can then be displayed by debuggers. `gdb`, `lldb` and `cdb` tests are also included for `f16` . `f16`/`f128` MSVC debug info issue: rust-lang#121837 Tracking issue: rust-lang#116909
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jul 8, 2024
…rister Add Natvis visualiser and debuginfo tests for `f16` To render `f16`s in debuggers on MSVC targets, this PR changes the compiler to output `f16`s as `struct f16 { bits: u16 }`, and includes a Natvis visualiser that manually converts the `f16`'s bits to a `float` which is can then be displayed by debuggers. `gdb`, `lldb` and `cdb` tests are also included for `f16` . `f16`/`f128` MSVC debug info issue: rust-lang#121837 Tracking issue: rust-lang#116909
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jul 9, 2024
…rister Add Natvis visualiser and debuginfo tests for `f16` To render `f16`s in debuggers on MSVC targets, this PR changes the compiler to output `f16`s as `struct f16 { bits: u16 }`, and includes a Natvis visualiser that manually converts the `f16`'s bits to a `float` which is can then be displayed by debuggers. `gdb`, `lldb` and `cdb` tests are also included for `f16` . `f16`/`f128` MSVC debug info issue: rust-lang#121837 Tracking issue: rust-lang#116909
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jul 9, 2024
…rister Add Natvis visualiser and debuginfo tests for `f16` To render `f16`s in debuggers on MSVC targets, this PR changes the compiler to output `f16`s as `struct f16 { bits: u16 }`, and includes a Natvis visualiser that manually converts the `f16`'s bits to a `float` which is can then be displayed by debuggers. `gdb`, `lldb` and `cdb` tests are also included for `f16` . `f16`/`f128` MSVC debug info issue: rust-lang#121837 Tracking issue: rust-lang#116909
Well, how can that be easy? =) I saw a few issues which seems not easy. I think we should define what is "easy". |
jieyouxu
added
E-hard
Call for participation: Hard difficulty. Experience needed to fix: A lot.
E-needs-investigation
Call for partcipation: This issues needs some investigation to determine current status
and removed
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
labels
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-debuginfo
Area: Debugging information in compiled programs (DWARF, PDB, etc.)
E-hard
Call for participation: Hard difficulty. Experience needed to fix: A lot.
E-needs-investigation
Call for partcipation: This issues needs some investigation to determine current status
F-f16_and_f128
`#![feature(f16)]`, `#![feature(f128)]`
O-windows-msvc
Toolchain: MSVC, Operating system: Windows
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
WG-debugging
Working group: Bad Rust debugging experiences
The code at
rust/compiler/rustc_codegen_llvm/src/debuginfo/metadata.rs
Lines 696 to 707 in 6cbf092
@rustbot label +F-f16_and_f128
The text was updated successfully, but these errors were encountered: