Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x clippy keeps nix-patching binaries #119442

Closed
Noratrieb opened this issue Dec 30, 2023 · 0 comments · Fixed by #121228
Closed

x clippy keeps nix-patching binaries #119442

Noratrieb opened this issue Dec 30, 2023 · 0 comments · Fixed by #121228
Assignees
@onur-ozkan
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@Noratrieb
Copy link
Member

On NixOS, when executing x clippy for the first time, clippy is downloaded and patched for nix. But every time I run x clippy after that, it still patches it.

nils@nixos ~/p/rust (master)> x clippy compiler -Aclippy::all -Dclippy::correctness
Building bootstrap
    Finished dev [unoptimized] target(s) in 0.04s

INFO: You seem to be using Nix.
attempting to patch /home/nils/projects/rust/build/x86_64-unknown-linux-gnu/stage0/bin/cargo-clippy
attempting to patch /home/nils/projects/rust/build/x86_64-unknown-linux-gnu/stage0/bin/clippy-driver
INFO: You seem to be using Nix.
attempting to patch /home/nils/projects/rust/build/x86_64-unknown-linux-gnu/stage0/bin/cargo-clippy
attempting to patch /home/nils/projects/rust/build/x86_64-unknown-linux-gnu/stage0/bin/clippy-driver
extracting /home/nils/projects/rust/build/cache/2023-12-22/clippy-beta-x86_64-unknown-linux-gnu.tar.xz to /home/nils/projects/rust/build/x86_64-unknown-linux-gnu/stage0
INFO: You seem to be using Nix.
attempting to patch /home/nils/projects/rust/build/x86_64-unknown-linux-gnu/stage0/bin/cargo-clippy
attempting to patch /home/nils/projects/rust/build/x86_64-unknown-linux-gnu/stage0/bin/clippy-driver
Checking stage0 library artifacts (x86_64-unknown-linux-gnu)

To reproduce: Be on NixOS (or patch bootstrap so that should_fix_bins_and_dylibs return true). Run x clippy several times.
@Noratrieb Noratrieb added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. labels Dec 30, 2023
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Dec 30, 2023
@onur-ozkan onur-ozkan removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Dec 30, 2023
@onur-ozkan onur-ozkan self-assigned this Feb 17, 2024
@onur-ozkan onur-ozkan mentioned this issue Feb 17, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 17, 2024
@matthiaskrgr
Rollup merge of rust-lang#121228 - onur-ozkan:fix-clippy-stamp-bug, r…
ad71ae1 
…=albertlarsan68

create stamp file for clippy

Due to missing stamp file, we were downloading (and applying nix patches if enabled) continuously every time `Config::download_clippy` was called. This change fixes that by creating stamp file at the end of the function.

Fixes rust-lang#119442
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 17, 2024
@matthiaskrgr
Rollup merge of rust-lang#121228 - onur-ozkan:fix-clippy-stamp-bug, r…
0739ce5 
…=albertlarsan68

create stamp file for clippy

Due to missing stamp file, we were downloading (and applying nix patches if enabled) continuously every time `Config::download_clippy` was called. This change fixes that by creating stamp file at the end of the function.

Fixes rust-lang#119442
@bors bors closed this as completed in 4ddc8e4 Feb 17, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Feb 17, 2024
@rust-timer
Unrolled build for rust-lang#121228
1959932 
Rollup merge of rust-lang#121228 - onur-ozkan:fix-clippy-stamp-bug, r=albertlarsan68

create stamp file for clippy

Due to missing stamp file, we were downloading (and applying nix patches if enabled) continuously every time `Config::download_clippy` was called. This change fixes that by creating stamp file at the end of the function.

Fixes rust-lang#119442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onur-ozkan onur-ozkan

Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

create stamp file for clippy onur-ozkan/rust
3 participants
@onur-ozkan @rustbot @Noratrieb