Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to add with overflow in GVN when building chrono-tz #119008

Closed
saethlin opened this issue Dec 16, 2023 · 0 comments · Fixed by #119052
Closed

Attempt to add with overflow in GVN when building chrono-tz #119008

saethlin opened this issue Dec 16, 2023 · 0 comments · Fixed by #119052
Labels
A-mir-opt Area: MIR optimizations C-bug Category: This is a bug. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ requires-debug-assertions This issue requires a build of rustc or tooling with debug-assertions in some way T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@saethlin
Copy link
Member

https://github.com/chronotope/chrono-tz on commit 97d1680189e61fbd66fcb1c52f6d51b55389919e

RUSTFLAGS="-Zinline-mir -Zmir-opt-level=1 -Zmir-enable-passes=+GVN -Zcross-crate-inline-threshold=yes -Copt-level=1" cargo +master-stage1 build

Where master-stage1 is a toolchain build with debug assertions.

   Compiling chrono-tz v0.8.4 (/home/ben/chrono-tz/chrono-tz)
thread 'rustc' panicked at compiler/rustc_mir_transform/src/gvn.rs:650:37:
attempt to add with overflow
stack backtrace:

rustc-ice-2023-12-16T04_53_09-27142.txt
@saethlin saethlin added I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-bug Category: This is a bug. A-mir-opt Area: MIR optimizations requires-debug-assertions This issue requires a build of rustc or tooling with debug-assertions in some way labels Dec 16, 2023
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Dec 16, 2023
@saethlin saethlin removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Dec 16, 2023
@cjgillot cjgillot mentioned this issue Dec 17, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 17, 2023
@matthiaskrgr
Rollup merge of rust-lang#119052 - cjgillot:gvn-index-overflow, r=com…
39fe059 
…piler-errors

Avoid overflow in GVN constant indexing.

Fixes rust-lang#118992
Fixes rust-lang#119008
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Dec 17, 2023
@rust-timer
Unrolled build for rust-lang#119052
5a7f7be 
Rollup merge of rust-lang#119052 - cjgillot:gvn-index-overflow, r=compiler-errors

Avoid overflow in GVN constant indexing.

Fixes rust-lang#118992
Fixes rust-lang#119008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-mir-opt Area: MIR optimizations C-bug Category: This is a bug. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ requires-debug-assertions This issue requires a build of rustc or tooling with debug-assertions in some way T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid overflow in GVN constant indexing. cjgillot/rust
2 participants
@saethlin @rustbot