-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICE suggestion must not have overlapping parts
with nested, malformed macro decl
#118786
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
C-bug
Category: This is a bug.
I-ICE
Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️
requires-debug-assertions
This issue requires a build of rustc or tooling with debug-assertions in some way
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
matthiaskrgr
added
I-ICE
Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
C-bug
Category: This is a bug.
labels
Dec 9, 2023
rustbot
added
the
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
label
Dec 9, 2023
Backtrace
Backtrace
Backtrace
|
matthiaskrgr
added
A-diagnostics
Area: Messages for errors, warnings, and lints
requires-debug-assertions
This issue requires a build of rustc or tooling with debug-assertions in some way
labels
Dec 9, 2023
saethlin
added
C-bug
Category: This is a bug.
and removed
C-bug
Category: This is a bug.
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
labels
Dec 10, 2023
This appears to stem from the span for the delimited block being changed here. I will work on a fix now and submit it. |
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Dec 17, 2023
Rollup merge of rust-lang#118928 - EliseZeroTwo:EliseZeroTwo/fix-issue-118786, r=cjgillot fix: Overlapping spans in delimited meta-vars Closes rust-lang#118786 Delimited meta-vars inside of MBE's spans were set to have the same opening and closing position resulting in an ICE when debug assertions were enabled and an error was present in the templated code. This ensures that the spans do not overlap, whilst still having the spans point at the usage of the meta-var inside the macro definition. It includes a regression test. 🖤
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
C-bug
Category: This is a bug.
I-ICE
Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️
requires-debug-assertions
This issue requires a build of rustc or tooling with debug-assertions in some way
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Code
Meta
rustc --version --verbose
:Error output
The problem seems to be this:
But it looks like rustc already gets the span wrong:
The text was updated successfully, but these errors were encountered: