Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

placement box #11779

Closed
brson opened this issue Jan 24, 2014 · 11 comments
Closed

placement box #11779

brson opened this issue Jan 24, 2014 · 11 comments
Assignees
@pnkfelix
Labels
P-medium Medium priority

Comments

@brson
Copy link
Contributor

brson commented Jan 24, 2014

I don't see an issue for our new heap construction syntax. Nominating.
@pnkfelix
Copy link
Member

Accepted for 1.0, P-backcompat-lang.

@pcwalton
Copy link
Contributor

pcwalton commented May 3, 2014

Nominating for removal from 1.0 because I believe this is satisfactorily complete for 1.0.

brson added a commit to brson/rust that referenced this issue May 3, 2014
@brson
Replace most ~exprs with 'box'. rust-lang#11779
a5be12c
brson added a commit to brson/rust that referenced this issue May 3, 2014
@brson
syntax: Warn on deprecated ~ exprs. rust-lang#11779
faa23b5
@brson
Copy link
Contributor Author

brson commented May 8, 2014

Lowering priority to P-high, instead of backcompat-lang.

@nikomatsakis
Copy link
Contributor

cc #18233

@aturon
Copy link
Member

aturon commented Jan 8, 2015

We do not necessarily need to implement this for 1.0-beta, but we need to at least decide on what our 1.0 story will be before then. Nominating for -beta.

@pnkfelix
Copy link
Member

pnkfelix commented Jan 8, 2015

Filing as 1.0-beta to ensure we make a decision about what backwards compatibility story is here

@pnkfelix pnkfelix modified the milestones: 1.0 beta, 1.0 Jan 8, 2015
@jroesch
Copy link
Member

jroesch commented Jan 8, 2015

cc me

@nikomatsakis
Copy link
Contributor

Assigning to felix as he's been working on this.

@pnkfelix pnkfelix mentioned this issue Jan 15, 2015
Closed
@pnkfelix
Copy link
Member

pnkfelix commented Feb 4, 2015

see rust-lang/rfcs#809

@pnkfelix
Copy link
Member

removing from 1.0 milestone. (box will be unstable for 1.0)

@pnkfelix pnkfelix removed this from the 1.0 beta milestone Mar 26, 2015
@steveklabnik
Copy link
Member

this issue has been superceded by #27779 as far as I can tell, let me know if it should still be open for some reason.

flip1995 pushed a commit to flip1995/rust that referenced this issue Nov 16, 2023
@bors
Auto merge of rust-lang#11779 - partiallytyped:11775, r=blyxyas
34b7d15 
[`mod_module_files`] Don't emit lint for mod.rs in tests

fixes: rust-lang#11775

current state: indiscriminately emits the lint for mod files in tests.

The following

```
tests/
  common/
    mod.rs
  test.rs
```

is a common pattern for code shared across the tests and is suggested in the rust book. The change adds an additional check to verify that the mod file is not in tests.

changelog: Fix [`mod_module_files`]: false positive for mod files in tests folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pnkfelix pnkfelix

Labels
P-medium Medium priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@steveklabnik @brson @nikomatsakis @pcwalton @pnkfelix @jroesch @aturon