-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust-1.74.0-beta fails to execute x.py install with: thread 'main' panicked at install.rs:59:17 - Failed the write access check for the current user. No such file or directory #117203
Comments
@nikic can I ping you on this? Beta is not compiling on gentoo, I assume at least one patch from nightly still needs to be backported to beta. |
There is #116349 that should have fixed that and it's |
Hi, I'm on latest beta from last week. If I apply #116349 locally and compile, I get access denied error:
|
* ACCESS DENIED: mkdir: /usr/lib/rust/1.74.0_beta
thread 'main' panicked at install.rs:78:5:
User doesn't have write access on `install.prefix` path in the `config.toml`. Logs says you don't have permission to put files into |
Interesting 🤔 Can you share your build configuration? |
it basically does this:
which translates to:
and the patch seems to make x.py ignore the DESTDIR="" command In the rust context, the build config you asked me to share is the config.toml? Have it attached for you, please feel free to ask for any additional information. also I can provide you with the full build log: build.log.gz |
Did you wait for whole process(x.py install) to be finished? I don't understand how mkdir gets you into access denied error for |
Maybe there is some confusion about relative and absolute path? The access denied error is valid, as x.py never should mess with /usr/lib/ in install, but use /var/tmp/portage/dev-lang/rust-1.74.0_beta/image/ as it's prefix, if you want to name it like that. |
True, there is a confusion between prefix and DESTDIR right now. I will fix it today. |
Thank you, I'm happy to test any patch before you commit it to master. |
You can test #117383 |
yes this works for me, please also beta nominate |
…larsan68 improve and fix `x install` Fix: Write access check of `prefix` and `sysconfdir` when DESTDIR is present. Improvement: Instead of repeatedly reading `DESTDIR` within each `fn prepare_dir` usage, read it once and pass it to the `fn prepare_dir`. Fixes rust-lang#117203
…larsan68 improve and fix `x install` Fix: Write access check of `prefix` and `sysconfdir` when DESTDIR is present. Improvement: Instead of repeatedly reading `DESTDIR` within each `fn prepare_dir` usage, read it once and pass it to the `fn prepare_dir`. Fixes rust-lang#117203
…larsan68 improve and fix `x install` Fix: Write access check of `prefix` and `sysconfdir` when DESTDIR is present. Improvement: Instead of repeatedly reading `DESTDIR` within each `fn prepare_dir` usage, read it once and pass it to the `fn prepare_dir`. Fixes rust-lang#117203
Rollup merge of rust-lang#117383 - onur-ozkan:fix-x-install, r=albertlarsan68 improve and fix `x install` Fix: Write access check of `prefix` and `sysconfdir` when DESTDIR is present. Improvement: Instead of repeatedly reading `DESTDIR` within each `fn prepare_dir` usage, read it once and pass it to the `fn prepare_dir`. Fixes rust-lang#117203
@onur-ozkan has this been beta-nominated? I'm new to this process, it's just I can't see a rollup pullrequest anywhere and the release of 1.74.0 is coming closer every day. |
It is #117383 (comment). cc @rust-lang/release |
@onur-ozkan for backport, the PR's responsible team (T-bootstrap) also needs to label it beta-accepted. Once it has both labels, the release team will handle the actual backport. |
hey everyone, I get this message from
x.py
wheninstall
is executed:It seems there are some backports still missing for beta, since I can fix this by reverting #116127 locally, and there are some subsequent fixes in nightly who seemed to have fixed the issue for good.
So, is there somewhere a list of the nightly backports needed to fix this problem? Thanks.
The text was updated successfully, but these errors were encountered: