Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken Link to Ayu theme in The rustdoc book, Section 4.1 #116977

Closed
lpnh opened this issue Oct 20, 2023 · 0 comments · Fixed by #117026
Closed

Broken Link to Ayu theme in The rustdoc book, Section 4.1 #116977

lpnh opened this issue Oct 20, 2023 · 0 comments · Fixed by #117026
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-rustdoc-themes Area: Themes for HTML pages generated by rustdoc C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@lpnh
Copy link

lpnh commented Oct 20, 2023

Location

The rustdoc book, Section 4.1 - What to include (and exclude)

Summary

Broken link found at the end of Section 4.1. The link text is "Ayu", which was intended to lead to an ayu.css file previously located in src/librustdoc/html/static/css/themes/. However, following a commit, all CSS files in the themes directory have been merged into src/librustdoc/html/static/css/rustdoc.css. The Ayu theme code is now found in rustdoc.css at L2384-L2574. Suggesting to update the link to point to the new location of the Ayu theme in rustdoc.css.
@lpnh lpnh added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Oct 20, 2023
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 20, 2023
@fmease fmease added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-bug Category: This is a bug. A-rustdoc-themes Area: Themes for HTML pages generated by rustdoc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Oct 20, 2023
@rmehri01 rmehri01 mentioned this issue Oct 21, 2023
Merged
@davidzr davidzr mentioned this issue Oct 21, 2023
Closed
@bors bors closed this as completed in 4ebc81a Oct 21, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 21, 2023
@rust-timer
Unrolled build for rust-lang#117026
018ec31 
Rollup merge of rust-lang#117026 - rmehri01:fix_ayu_theme_link, r=notriddle

Fix broken link to Ayu theme in the rustdoc book

Fixes rust-lang#116977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-rustdoc-themes Area: Themes for HTML pages generated by rustdoc C-bug Category: This is a bug. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
3 participants
@fmease @rustbot @lpnh