Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Zunpretty=expanded does not emit dep-info anymore (1.68 -> 1.69) #112898

Closed
ojeda opened this issue Jun 21, 2023 · 3 comments · Fixed by #114476
Closed

-Zunpretty=expanded does not emit dep-info anymore (1.68 -> 1.69) #112898

ojeda opened this issue Jun 21, 2023 · 3 comments · Fixed by #114476
Labels
C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. requires-nightly This issue requires a nightly compiler in some way.

Comments

@ojeda
Copy link
Contributor

ojeda commented Jun 21, 2023

rm -f x.d && echo 'fn main() {}' |
    RUSTC_BOOTSTRAP=1 rustup run 1.68.2 rustc - --emit=dep-info=x.d -Zunpretty=expanded >/dev/null &&
    cat x.d
x.d: 
rm -f x.d && echo 'fn main() {}' |
    RUSTC_BOOTSTRAP=1 rustup run 1.69.0 rustc - --emit=dep-info=x.d -Zunpretty=expanded >/dev/null &&
    cat x.d
cat: x.d: No such file or directory

Related: #93201 (i.e. having expanded as an actual --emit would be nice).

We use -Zunpretty=expanded in the kernel to provide the expanded output in .rsi outputs/targets. The dependency information is not critical, but the change made our Make target fail (so we need a change on the kernel side), and it would be nice nevertheless to have the dependency information (assuming it is accurate), e.g. we also use it for similar outputs like .ll and .s.

@ojeda ojeda added C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. labels Jun 21, 2023
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jun 21, 2023
@jyn514 jyn514 added the requires-nightly This issue requires a nightly compiler in some way. label Jun 22, 2023
@apiraino
Copy link
Contributor

Bisection seems to lead to commit d7948c8 but I am not sure / cant say if really related. The mentioned issue #93201 was opened before that commit was merged 🤔 @oli-obk @petrochenkov wdy?

@oli-obk
Copy link
Contributor

oli-obk commented Jun 27, 2023

This looks like another symptom of #93201

We'll likely keep regressing this by accident without a test. I don't know why #93201 was fixed between when it was reported and 1.68

@ojeda
Copy link
Contributor Author

ojeda commented Aug 6, 2023

Thanks for fixing this @Urgau!

github-actions bot pushed a commit to rust-lang/miri that referenced this issue Aug 8, 2023
Fix missing dependency file with `-Zunpretty`

This PR force the `output_filenames` to be run ~~in every early exits like~~ when using `-Zunpretty`, so to respect the `dep-info` flag.

Fixes rust-lang/rust#112898
r? `@oli-obk`
@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. requires-nightly This issue requires a nightly compiler in some way.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants