Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen-backends = ["rustc_codegen_cranelift"] should give a better error message #109315

Closed
jyn514 opened this issue Mar 18, 2023 · 1 comment · Fixed by #114278
Closed

codegen-backends = ["rustc_codegen_cranelift"] should give a better error message #109315

jyn514 opened this issue Mar 18, 2023 · 1 comment · Fixed by #114278
Assignees
@onur-ozkan
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-cranelift Things relevant to the [future] cranelift backend A-diagnostics Area: Messages for errors, warnings, and lints T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Mar 18, 2023 •
edited by rustbot
Loading

I tried this code:

echo 'codegen-backends = ["rustc_codegen_cranelift"]` >> config.toml
x test ui

I expected to see this happen: An error saying that rustc_codegen_cranelift is invalid and should be cranelift instead.

Instead, this happened:

Building stage0 codegen backend rustc_codegen_cranelift
error: manifest path `/home/jyn/src/rust2/compiler/rustc_codegen_rustc_codegen_cranelift/Cargo.toml` does not exist

Meta

HEAD is branched from 13afbda
@jyn514 jyn514 added A-diagnostics Area: Messages for errors, warnings, and lints T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-cranelift Things relevant to the [future] cranelift backend A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself labels Mar 18, 2023
@onur-ozkan
Copy link
Member

@rustbot claim

@onur-ozkan onur-ozkan mentioned this issue Jul 31, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 10, 2023
@matthiaskrgr
Rollup merge of rust-lang#114278 - ozkanonur:validate-codegen-backend…
87c94dd 
…-config, r=clubby789

better error handling for `rust.codegen-backends` on deserialization

Fixes rust-lang#109315
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 10, 2023
@matthiaskrgr
Rollup merge of rust-lang#114278 - ozkanonur:validate-codegen-backend…
ed7efeb 
…-config, r=clubby789

better error handling for `rust.codegen-backends` on deserialization

Fixes rust-lang#109315
@bors bors closed this as completed in b9648d4 Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onur-ozkan onur-ozkan

Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-cranelift Things relevant to the [future] cranelift backend A-diagnostics Area: Messages for errors, warnings, and lints T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

better error handling for rust.codegen-backends on deserialization onur-ozkan/rust
2 participants
@jyn514 @onur-ozkan