Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x.py fix is broken #107501

Closed
est31 opened this issue Jan 31, 2023 · 0 comments · Fixed by #107626
Closed

x.py fix is broken #107501

est31 opened this issue Jan 31, 2023 · 0 comments · Fixed by #107626
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@est31
Copy link
Member

est31 commented Jan 31, 2023

If you try to run x.py fix you'll be getting an error:

$ ./x.py fix 
Building bootstrap
    Finished dev [unoptimized] target(s) in 0.09s
Checking stage0 library artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Checking test v0.0.0 (/rust/library/test)
error[E0463]: can't find crate for `test`
 --> library/test/src/stats/tests.rs:3:1
  |
3 | extern crate test;
  | ^^^^^^^^^^^^^^^^^^ can't find crate

error[E0463]: can't find crate for `test`
    --> library/test/src/stats/tests.rs:43:1
     |
42   |   #[test]
     |   ------- in this procedural macro expansion
43   | / fn test_min_max_nan() {
44   | |     let xs = &[1.0, 2.0, f64::NAN, 3.0, 4.0];
45   | |     let summary = Summary::new(xs);
46   | |     assert_eq!(summary.min, 1.0);
47   | |     assert_eq!(summary.max, 4.0);
48   | | }
     | |_^ can't find crate
     |
    ::: library/core/src/macros/mod.rs:1495:5
     |
1495 |       pub macro test($item:item) {
     |       -------------- in this expansion of `#[test]`

[tons of repetitions of this error for each test in the test crate]

@rustbot label T-bootstrap

@est31 est31 added the C-bug Category: This is a bug. label Jan 31, 2023
@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jan 31, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 14, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 14, 2023
@bors bors closed this as completed in 2c1d3e9 Feb 15, 2023
RalfJung pushed a commit to RalfJung/miri that referenced this issue Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants