Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign compiler diagnostic logging #10492

Closed
emberian opened this issue Nov 14, 2013 · 8 comments · Fixed by #30711
Closed

Redesign compiler diagnostic logging #10492

emberian opened this issue Nov 14, 2013 · 8 comments · Fixed by #30711
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@emberian
Copy link
Member

The interface in syntax::diagnostic is super janky and causes a lot of problems with code higher up in the stack (it prevents anything from being sendable, for example). Rework it to use idiomatic traits, include a JSON output mode, and add the ability to work in #2092.
@ghost ghost assigned emberian Nov 14, 2013
@emberian
Copy link
Member Author

(I'm actively working on this)

@huonw
Copy link
Member

huonw commented Nov 14, 2013

cc #3533.

@emberian
Copy link
Member Author

#3533 is not in scope for this.

@huonw huonw mentioned this issue Mar 1, 2014
Merged
@emberian
Copy link
Member Author

I'm not actively working on this.

@emberian emberian removed their assignment Mar 30, 2014
@ahmedcharles
Copy link
Contributor

@cmr Did you have any code or suggestions about changes that should be made beyond the comments above?

@emberian
Copy link
Member Author

@ahmedcharles I spent a few days working on this and then got busy with school. I started with rewriting syntax::diagnostic to look like what I thought it should, and then got lost in refactoring the compiler to compensate.

@brson brson mentioned this issue Jan 13, 2015
Closed
@steveklabnik
Copy link
Member

Triage: @cmr what do you think of this today?

@emberian
Copy link
Member Author

@steveklabnik I think this is still desirable, even more so for tools like Cargo to "understand" what rustc is outputting.

@huonw huonw mentioned this issue Jan 5, 2016
Merged
bors added a commit that referenced this issue Jan 15, 2016
@bors
Auto merge of #30711 - nrc:json-errs, r=huonw
d8869d3 
The compiler can emit errors and warning in JSON format. This is a more easily machine readable form then the usual error output.

Closes #10492, closes #14863.
@bruno-medeiros bruno-medeiros mentioned this issue May 12, 2016
Open
flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 11, 2023
@bors
Auto merge of rust-lang#10492 - schubart:collection_is_never_read_uni…
3b5b2ed 
…t_type, r=Manishearth

`collection_is_never_read`: Handle unit type

changelog: [`collection_is_never_read`]: Fix false negative
fixes: rust-lang#10488
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Emit JSON errors nrc/rust
4 participants
@steveklabnik @emberian @huonw @ahmedcharles