Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miri no longer builds after rust-lang/rust#97802 #101352

Closed
rust-highfive opened this issue Sep 2, 2022 · 4 comments · Fixed by rust-lang/miri#2532
Closed

miri no longer builds after rust-lang/rust#97802 #101352

rust-highfive opened this issue Sep 2, 2022 · 4 comments · Fixed by rust-lang/miri#2532
Assignees
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #97802, I observed that the tool miri no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @Enselic, do you think you would have time to do the follow-up work?
If so, that would be great!

@Enselic
Copy link
Member

Enselic commented Sep 3, 2022

Fixed by rust-lang/miri#2532

@RalfJung
Copy link
Member

RalfJung commented Sep 3, 2022

Duplicate of #101344.

@RalfJung RalfJung closed this as not planned Won't fix, can't repro, duplicate, stale Sep 3, 2022
@ChrisDenton
Copy link
Member

This doesn't look like a duplicate?

https://github.com/rust-lang-ci/rust/runs/8164066860?check_suite_focus=true#step:25:7879

error[E0532]: expected unit struct, unit variant or constant, found struct variant `EntryFnType::Main`
   --> src\tools\miri\src\eval.rs:280:9
    |
280 |         EntryFnType::Main => {
    |         ^^^^^^^^^^^^^^^^^ help: use struct pattern syntax instead: `EntryFnType::Main { /* fields */ }`
    |
   ::: D:\a\rust\rust\compiler\rustc_session\src\config.rs:803:5
    |
803 |     Main {
    |     ---- `EntryFnType::Main` defined here

@RalfJung
Copy link
Member

RalfJung commented Sep 3, 2022 via email

bors added a commit to rust-lang/miri that referenced this issue Sep 3, 2022
Fix build with `#[unix_sigpipe = "..."]` support in rustc

Closes rust-lang/rust#101352

CC `@RalfJung` `@oli-obk`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants