Skip to content

Commit

Permalink
miri engine: fix treatment of abort intrinsic
Browse files Browse the repository at this point in the history
  • Loading branch information
RalfJung committed Mar 12, 2020
1 parent 54b7d21 commit e9c9657
Showing 1 changed file with 5 additions and 8 deletions.
13 changes: 5 additions & 8 deletions src/librustc_mir/interpret/intrinsics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -84,14 +84,15 @@ impl<'mir, 'tcx, M: Machine<'mir, 'tcx>> InterpCx<'mir, 'tcx, M> {
let substs = instance.substs;
let intrinsic_name = self.tcx.item_name(instance.def_id());

// We currently do not handle any intrinsics that are *allowed* to diverge,
// but `transmute` could lack a return place in case of UB.
// First handle intrinsics without return place.
let (dest, ret) = match ret {
Some(p) => p,
None => match intrinsic_name {
sym::transmute => throw_ub!(Unreachable),
sym::transmute => throw_ub_format!("transmuting to uninhabited type"),
sym::abort => M::abort(self)?,
// Unsupported diverging intrinsic.
_ => return Ok(false),
},
Some(p) => p,
};

// Keep the patterns in this match ordered the same as the list in
Expand All @@ -103,10 +104,6 @@ impl<'mir, 'tcx, M: Machine<'mir, 'tcx>> InterpCx<'mir, 'tcx, M> {
self.write_scalar(location.ptr, dest)?;
}

sym::abort => {
M::abort(self)?;
}

sym::min_align_of
| sym::pref_align_of
| sym::needs_drop
Expand Down

0 comments on commit e9c9657

Please sign in to comment.