Skip to content

Commit

Permalink
Auto merge of #27272 - eefriedman:closure-const-crash, r=nikomatsakis
Browse files Browse the repository at this point in the history
Fixes issue #27268.

r? @nikomatsakis
  • Loading branch information
bors committed Jul 26, 2015
2 parents a42e21d + eefeba0 commit cf7e825
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 25 deletions.
32 changes: 7 additions & 25 deletions src/librustc_typeck/check/upvar.rs
Original file line number Diff line number Diff line change
Expand Up @@ -93,22 +93,8 @@ impl<'a, 'tcx, 'v> Visitor<'v> for SeedBorrowKind<'a, 'tcx> {
visit::walk_expr(self, expr);
}

fn visit_fn(&mut self,
fn_kind: visit::FnKind<'v>,
decl: &'v ast::FnDecl,
block: &'v ast::Block,
span: Span,
_id: ast::NodeId)
{
match fn_kind {
visit::FkItemFn(..) | visit::FkMethod(..) => {
// ignore nested fn items
}
visit::FkFnBlock => {
visit::walk_fn(self, fn_kind, decl, block, span);
}
}
}
// Skip all items; they aren't in the same context.
fn visit_item(&mut self, _: &'v ast::Item) { }
}

impl<'a,'tcx> SeedBorrowKind<'a,'tcx> {
Expand Down Expand Up @@ -515,16 +501,12 @@ impl<'a, 'tcx, 'v> Visitor<'v> for AdjustBorrowKind<'a, 'tcx> {
span: Span,
id: ast::NodeId)
{
match fn_kind {
visit::FkItemFn(..) | visit::FkMethod(..) => {
// ignore nested fn items
}
visit::FkFnBlock => {
visit::walk_fn(self, fn_kind, decl, body, span);
self.analyze_closure(id, span, decl, body);
}
}
visit::walk_fn(self, fn_kind, decl, body, span);
self.analyze_closure(id, span, decl, body);
}

// Skip all items; they aren't in the same context.
fn visit_item(&mut self, _: &'v ast::Item) { }
}

impl<'a,'tcx> euv::Delegate<'tcx> for AdjustBorrowKind<'a,'tcx> {
Expand Down
13 changes: 13 additions & 0 deletions src/test/run-pass/issue-27268.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

fn main() {
const _C: &'static Fn() = &||{};
}

0 comments on commit cf7e825

Please sign in to comment.