Skip to content

Commit

Permalink
Auto merge of #113583 - asquared31415:tidy_no_issue_tests, r=workingj…
Browse files Browse the repository at this point in the history
…ubilee

add tidy check that forbids issue-XXXX and ice-XXXX test filenames

Helps with #113345 by preventing any future tests with non-descriptive names from being added.

This PR only checks modified ui test files because there are far too many existing problematic tests to be fixed at once:
3063/15424 (~19.86%) `*.rs` ui test files match `^issue[-_ ]?\d+$`.
Another 1349 files, totaling ~28.60% of all ui test files, contain that pattern in addition to some other text, where they should probably omit it in favor of a comment.

note: between the creation of this PR and 2023-07-25 (14 days), 10 more tests were added that failed this check.

r? `@workingjubilee`
  • Loading branch information
bors committed Jul 26, 2023
2 parents 98db99f + 13e2abf commit cf34adb
Show file tree
Hide file tree
Showing 2 changed files with 4,329 additions and 6 deletions.
Loading

0 comments on commit cf34adb

Please sign in to comment.