Skip to content

Commit

Permalink
Rollup merge of #36223 - abhiQmar:e0558-formatting, r=jonathandturner
Browse files Browse the repository at this point in the history
Update compiler error E0558 to use new error format

Fixes #36196 part of #35233

r? @jonathandturner
  • Loading branch information
Jonathan Turner authored Sep 2, 2016
2 parents 5284bee + 18434f9 commit c701490
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
5 changes: 3 additions & 2 deletions src/libsyntax/attr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -438,8 +438,9 @@ pub fn find_export_name_attr(diag: &Handler, attrs: &[Attribute]) -> Option<Inte
} else {
struct_span_err!(diag, attr.span, E0558,
"export_name attribute has invalid format")
.help("use #[export_name=\"*\"]")
.emit();
.span_label(attr.span,
&format!("did you mean #[export_name=\"*\"]?"))
.emit();
None
}
} else {
Expand Down
5 changes: 4 additions & 1 deletion src/test/compile-fail/E0558.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#[export_name] //~ ERROR E0558
#[export_name]
//~^ ERROR E0558
//~| NOTE did you mean #[export_name="*"]?

pub fn something() {}

fn main() {}

0 comments on commit c701490

Please sign in to comment.