Skip to content

Commit

Permalink
Auto merge of #57484 - alexcrichton:fix-nightlies, r=Mark-Simulacru
Browse files Browse the repository at this point in the history
Integrate miri into build-manifest

This fixes a mistake where miri was accidentally left out of the
build-manifest parsing, meaning that today's nightly generated a
manifest with invalid urls!

Fixes #57488.
  • Loading branch information
bors committed Jan 10, 2019
2 parents 6ecad33 + dd326f8 commit c2d381d
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/bootstrap/dist.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1984,14 +1984,14 @@ impl Step for HashSign {
cmd.arg(distdir(builder));
cmd.arg(today.trim());
cmd.arg(builder.rust_package_vers());
cmd.arg(addr);
cmd.arg(builder.package_vers(&builder.release_num("cargo")));
cmd.arg(builder.package_vers(&builder.release_num("rls")));
cmd.arg(builder.package_vers(&builder.release_num("clippy")));
cmd.arg(builder.package_vers(&builder.release_num("miri")));
cmd.arg(builder.package_vers(&builder.release_num("rustfmt")));
cmd.arg(builder.llvm_tools_package_vers());
cmd.arg(builder.lldb_package_vers());
cmd.arg(addr);

builder.create_dir(&distdir(builder));

Expand Down
17 changes: 16 additions & 1 deletion src/tools/build-manifest/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ struct Builder {
rustfmt_release: String,
llvm_tools_release: String,
lldb_release: String,
miri_release: String,

input: PathBuf,
output: PathBuf,
Expand All @@ -207,6 +208,7 @@ struct Builder {
rustfmt_version: Option<String>,
llvm_tools_version: Option<String>,
lldb_version: Option<String>,
miri_version: Option<String>,

rust_git_commit_hash: Option<String>,
cargo_git_commit_hash: Option<String>,
Expand All @@ -215,6 +217,7 @@ struct Builder {
rustfmt_git_commit_hash: Option<String>,
llvm_tools_git_commit_hash: Option<String>,
lldb_git_commit_hash: Option<String>,
miri_git_commit_hash: Option<String>,

should_sign: bool,
}
Expand All @@ -237,13 +240,14 @@ fn main() {
let output = PathBuf::from(args.next().unwrap());
let date = args.next().unwrap();
let rust_release = args.next().unwrap();
let s3_address = args.next().unwrap();
let cargo_release = args.next().unwrap();
let rls_release = args.next().unwrap();
let clippy_release = args.next().unwrap();
let miri_release = args.next().unwrap();
let rustfmt_release = args.next().unwrap();
let llvm_tools_release = args.next().unwrap();
let lldb_release = args.next().unwrap();
let s3_address = args.next().unwrap();

// Do not ask for a passphrase while manually testing
let mut passphrase = String::new();
Expand All @@ -259,6 +263,7 @@ fn main() {
rustfmt_release,
llvm_tools_release,
lldb_release,
miri_release,

input,
output,
Expand All @@ -274,6 +279,7 @@ fn main() {
rustfmt_version: None,
llvm_tools_version: None,
lldb_version: None,
miri_version: None,

rust_git_commit_hash: None,
cargo_git_commit_hash: None,
Expand All @@ -282,6 +288,7 @@ fn main() {
rustfmt_git_commit_hash: None,
llvm_tools_git_commit_hash: None,
lldb_git_commit_hash: None,
miri_git_commit_hash: None,

should_sign,
}.build();
Expand All @@ -297,6 +304,7 @@ impl Builder {
self.llvm_tools_version = self.version("llvm-tools", "x86_64-unknown-linux-gnu");
// lldb is only built for macOS.
self.lldb_version = self.version("lldb", "x86_64-apple-darwin");
self.miri_version = self.version("miri", "x86_64-unknown-linux-gnu");

self.rust_git_commit_hash = self.git_commit_hash("rust", "x86_64-unknown-linux-gnu");
self.cargo_git_commit_hash = self.git_commit_hash("cargo", "x86_64-unknown-linux-gnu");
Expand All @@ -306,6 +314,7 @@ impl Builder {
self.llvm_tools_git_commit_hash = self.git_commit_hash("llvm-tools",
"x86_64-unknown-linux-gnu");
self.lldb_git_commit_hash = self.git_commit_hash("lldb", "x86_64-unknown-linux-gnu");
self.miri_git_commit_hash = self.git_commit_hash("miri", "x86_64-unknown-linux-gnu");

self.digest_and_sign();
let manifest = self.build_manifest();
Expand Down Expand Up @@ -516,6 +525,8 @@ impl Builder {
format!("llvm-tools-{}-{}.tar.gz", self.llvm_tools_release, target)
} else if component == "lldb" || component == "lldb-preview" {
format!("lldb-{}-{}.tar.gz", self.lldb_release, target)
} else if component == "miri" || component == "miri-preview" {
format!("miri-{}-{}.tar.gz", self.miri_release, target)
} else {
format!("{}-{}-{}.tar.gz", component, self.rust_release, target)
}
Expand All @@ -534,6 +545,8 @@ impl Builder {
&self.llvm_tools_version
} else if component == "lldb" || component == "lldb-preview" {
&self.lldb_version
} else if component == "miri" || component == "miri-preview" {
&self.miri_version
} else {
&self.rust_version
}
Expand All @@ -552,6 +565,8 @@ impl Builder {
&self.llvm_tools_git_commit_hash
} else if component == "lldb" || component == "lldb-preview" {
&self.lldb_git_commit_hash
} else if component == "miri" || component == "miri-preview" {
&self.miri_git_commit_hash
} else {
&self.rust_git_commit_hash
}
Expand Down

0 comments on commit c2d381d

Please sign in to comment.