-
Notifications
You must be signed in to change notification settings - Fork 13k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
run: Process::new() should take &[Str] instead of &[~str] for args
Fixes #7928.
- Loading branch information
Showing
3 changed files
with
38 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a80d79c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from erickt
at lilyball@a80d79c
a80d79c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging kballard/rust/process-new-args = a80d79c into auto
a80d79c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kballard/rust/process-new-args = a80d79c merged ok, testing candidate = a75d4cae
a80d79c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1212
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1209
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1212
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/318
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/318
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1228
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/319
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/319
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1228
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/319
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/319
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/400
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/318
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/318
exception: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/997