Skip to content

Commit

Permalink
Rollup merge of #132182 - jieyouxu:downgrade-untranslatable, r=compil…
Browse files Browse the repository at this point in the history
…er-errors

Downgrade `untranslatable_diagnostic` and `diagnostic_outside_of_impl` to `allow`

Current implementation of translatable diagnostics infrastructure unfortunately causes some friction for compiler contributors. While we don't have a redesign that causes less friction in place, let's downgrade the internal `untranslatable_diagnostic` and `diagnostic_outside_of_impl` lints so we don't indicate to contributors that they *have* to use the current translation infra.

I purposefully left `#[allow(untranslatable_diagnostic)]` and `#[allow(diagnostic_outside_of_impl)]` instances untouched because that seems like unnecessary additional churn.

See <#132181> for context.

r? `@davidtwco` (or wg-diagnostics/compiler)
  • Loading branch information
matthiaskrgr authored Oct 26, 2024
2 parents 1f6cb85 + 5f47391 commit 5dd6010
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions compiler/rustc_lint/src/internal.rs
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ declare_tool_lint! {
/// More details on translatable diagnostics can be found
/// [here](https://rustc-dev-guide.rust-lang.org/diagnostics/translation.html).
pub rustc::UNTRANSLATABLE_DIAGNOSTIC,
Deny,
Allow,
"prevent creation of diagnostics which cannot be translated",
report_in_external_macro: true
}
Expand All @@ -440,7 +440,7 @@ declare_tool_lint! {
/// More details on diagnostics implementations can be found
/// [here](https://rustc-dev-guide.rust-lang.org/diagnostics/diagnostic-structs.html).
pub rustc::DIAGNOSTIC_OUTSIDE_OF_IMPL,
Deny,
Allow,
"prevent diagnostic creation outside of `Diagnostic`/`Subdiagnostic`/`LintDiagnostic` impls",
report_in_external_macro: true
}
Expand Down

0 comments on commit 5dd6010

Please sign in to comment.